search

glue-viz / glue

Linked Data Visualizations Across Multiple Files
http://glueviz.org
Other
721 stars 152 forks source link

Fix Qt6 bug that prevented layers from being re-enabled #2409

Closed jfoster17 closed 1 year ago

jfoster17 commented 1 year ago

Description

In Qt6, check boxes emit integers instead of the proper enum (https://bugreports.qt.io/browse/QTBUG-104688). Current logic for enabling/disabling layer artists checks the value emitted against the Qt.CheckState enum, which means that the user cannot make a layer artist they have turned not-visible visible again.

This PR fixes this behavior in the layer artist view by checking for the type of the value emitted by the checkbox and adds a test for it. I have not exhaustively checked that this problem does not occur with other checkboxes elsewhere in the GUI with Qt 6.

jfoster17 commented 1 year ago

Sorry, I made a garbage merge here. I'll just close this PR and open a new one!