search

glue-viz / glue

Linked Data Visualizations Across Multiple Files
http://glueviz.org
Other
740 stars 153 forks source link

Skip `test_save_aggregate_slice` for Numpy 1.25.x and unpin numpy-dev #2429

Closed dhomeier closed 1 year ago

dhomeier commented 1 year ago

Description

The GlueSerializer failure/hang first reported in #2353 has now made it into Numpy 1.25, so to keep jobs from just timing out (and burning CI hours), this pins all tests to 1.24.x as a temporary workaround. Alternatively one could skip test_save_aggregate_slice conditionally on Numpy >= 1.25, but that would leave that test to be run in only one or two tests – but perhaps better, than lagging by an entire Numpy release with everything else? Might reactivate an lts job with numpy==1.24.*...

Workaround for #2428

astrofrog commented 1 year ago

I think I would rather skip one test if possible as you suggest?

dhomeier commented 1 year ago

Done. It's still tested in the py38 and py311-lts envs now.

Any thoughts how to address the actual GlueSerializer failure? Something like https://github.com/numpy/numpy/pull/23034 (and if so, would this have to be done upstream)?