Remove Qt-specific code being split into glue-qt

glue-viz / glue

Linked Data Visualizations Across Multiple Files

http://glueviz.org

Other

742 stars 153 forks source link

Remove Qt-specific code being split into glue-qt #2431

Closed astrofrog closed 1 year ago

astrofrog commented 1 year ago

This is part of https://github.com/glue-viz/glue/issues/2430

[x] Rebase once https://github.com/glue-viz/glue/pull/2432 is merged
[x] Make sure that this works correctly with glue-qt
[x] Test that all downstream packages that don't need the Qt code work seamlessly with this version
- [x] glue-jupyter
- [x] jdaviz
- [x] glue-astronomy - with https://github.com/glue-viz/glue-astronomy/pull/95
- [x] glue-geospatial
- [x] glue-medical
[x] Add back compatibility imports for Qt with deprecation warnings

Packages that will need to be updated to use glue-qt wherever relevant:

[ ] glue-plotly - see https://github.com/glue-viz/glue-plotly/issues/41
[ ] glue-solar
[ ] glue-wwt - see https://github.com/glue-viz/glue-wwt/pull/98
[ ] glue-vispy-viewers - see https://github.com/glue-viz/glue-vispy-viewers/pull/378

Carifio24 commented 1 year ago

I think glue-wwt should be in the "needs updating" list as well, as it has some Qt-based glue imports.

dhomeier commented 1 year ago

Tests for glue-jupyter are passing with this version and no Qt installed (except for those requiring glue-vispy-viewers, which cannot be installed without PyQt).

astrofrog commented 1 year ago

@dhomeier - hmm good point about glue-vispy-viewers - I think we should probably move the 3D state objects out of glue-vispy-viewers and into glue-core since they should be reasonably generic, and then we could depend on that instead of glue-vispy-viewers in glue-jupyter.

dhomeier commented 1 year ago

except for those requiring glue-vispy-viewers, which cannot be installed without PyQt).

The depency is only on conda-forge though; with pip-installed glue-vispy-viewers the other tests are passing as well...

astrofrog commented 1 year ago

I think the thing is that glue-jupyter does depend on glue-vispy-viewers for the 3D volume rendering viewer but we just haven't declared the dependency. However we should be able to refactor things to not have that dependency at all. I think I will delay this until after glue-core and glue-qt are split.

astrofrog commented 1 year ago

I'm going to go ahead and merge this as I think it is ready. I will also merge https://github.com/glue-viz/glue-qt/pull/1 shortly. I will then do a release of glue-qt and add it as a dependency in glue-core so that glue-core should then continue to function as before just with deprecation warnings being raised now when Qt-related functionality is accessed.