search

glue-viz / glue

Linked Data Visualizations Across Multiple Files
http://glueviz.org
Other
740 stars 153 forks source link

Add CI for Python 3.13 and update dev envs #2518

Closed dhomeier closed 1 month ago

dhomeier commented 2 months ago

Description

Introducing test jobs for currently 3.13rc2 and pushing the py310-test-dev envs, which are now stuck at Astropy 6.1.3, to higher Python versions.

Non-dev job for py313 is failing on missing libhdf5-dev when trying to build h5py from source; don't know how to install the apt for just a specific env. I have down-versioned the windows-dev job here so it runs with astropy 6.1.3; upgrading to py312 produced the same data_factory failures

E AssertionError: assert <function astropy_tabular_data at 0x0000020F8CEE2C00> is <function img_data at 0x0000020F8CEE8FE0>

but the also occur with the non-dev Windows job, so it appears to be a Python 3.11+ issue on that platform. As far as I can tell this is incorrectly identifying the .png file as readable as an astropy_tabular_data "Catalog". @pllim any ideas what could have happened there?

Addresses #2517

pllim commented 2 months ago

Looks like it tests some sort of third-party PNG loader, so I am not sure. What is this actually testing? That df.find_factory(fname) must be the same object as df.img_data? Perhaps somehow a copy is made on Windows, breaking that assumption?

pllim commented 2 months ago

Did this test ever pass before on Windows?

dhomeier commented 1 month ago

It did, and does for Python <=3.10. Turned out to be a locale/encoding issue hopefully solved in #2519.