gluent / goe

GOE: a simple and flexible way to copy data from an Oracle Database to Google BigQuery.
Apache License 2.0
8 stars 2 forks source link

fix: Close connection used to get database version during Offload Transport #162

Closed nj1973 closed 5 months ago

nj1973 commented 5 months ago

We intentionally close Oracle connections during Offload transport to get around problems with idle sessions being sniped. We recently introduced a bug by moving code that checked the oracle version to later in the process of building a transport source query without including a disconnect. Due to this a second partition batch failed with ORA-3113.

If Offload transport used OracleFrontendApi then this would not have happened, I've created an issue for that, https://github.com/gluent/goe/issues/161, but for now we should introduce the missing disconnect. That is what this PR does.