feat: Round sampled Oracle NUMBER(17|18) up to GOE INT_38

gluent / goe

GOE: a simple and flexible way to copy data from an Oracle Database to Google BigQuery.

Apache License 2.0

8 stars 2 forks source link

feat: Round sampled Oracle NUMBER(17|18) up to GOE INT_38 #197

Closed nj1973 closed 3 weeks ago

nj1973 commented 3 weeks ago

This PR changes the canonical column from INT8 to INT38 for sampled Oracle columns when the sampled precision is 17 or 18. The idea being that sampled precisions are not 100% accurate and therefore we should err on the side of caution when the sampled precision is close to the max size of integer 8.