Refactor remaining story integration tests

[nj1973]

In issue https://github.com/gluent/goe/issues/35 we converted a few essential story tests to be functional in this new repo.

This issue is to work on converting the remaining tests in tests/integration/test_sets/stories/test_stories/ creating new tests in tests/integration/scenarios/.

You can use the existing tests as templates for how new ones should look:

$ ls -1 tests/integration/scenarios/test_*.py
tests/integration/scenarios/test_cli_api.py
tests/integration/scenarios/test_data_type_controls.py
tests/integration/scenarios/test_identifiers.py
tests/integration/scenarios/test_offload_basic.py
tests/integration/scenarios/test_offload_rpa.py

The tests yet to convert are (the ones with question marks might be irrelevant and ripe for removal):

• agg_validate.py (?)
• backend_stats.py
• cli_api_nossh.py
• hybrid_view_service.py (?)
• listener_orchestration.py
• mssql.py (?)
• netezza.py (?)
• offload_backend_part.py
• offload_esoteric.py (this should be renamed test_offload_advanced.py or similar)
• offload_full.py
• offload_hash_bucket.py (only need the part of this relating to Synabse hash column)
• offload_list_rpa.py
• offload_lpa.py
• offload_part_fn.py
• offload_pbo.py (intra day only)
• offload_sorting.py
• offload_subpart.py
• offload_transport.py
• orchestration_locks.py
• orchestration_step_control.py
• schema_sync.py (?)

[nj1973]

https://github.com/gluent/goe/issues/48 is a pre-req to this issue

[nj1973]

I've partially added PBO tests:

• test_offload_pbo.py (fully added)
• test_offload_pbo_late.py (partially added)
• test_offload_pbo_intra.py (not done at all)

[nj1973]

offload_esoteric has been migrated to the new tests.

[nj1973]

Converted

• orchestration_locks.py
• orchestration_step_control.py

[nj1973]

Converted

• offload_part_fn.py
• offload_sorting.py

[nj1973]

The new todo list:

• agg_validate.py (?)
• backend_stats.py
• cli_api_nossh.py
• listener_orchestration.py
• offload_backend_part.py
• offload_full.py (we should add a hash partitioned table to this and rename test_offload_full_part.py)
• offload_hash_bucket.py (only need the part of this relating to Synapse hash column)
• offload_list_rpa.py
• offload_lpa.py (full tests only)
• offload_pbo.py (intra day only)
• offload_subpart.py
• offload_transport.py
• schema_sync.py (?)

[nj1973]

Re-opening for remaining tests to be refactored.

[nj1973]

Only run test_offload_lpa.py::test_offload_lpa_unicode if NLS_LANG is set.

[nj1973]

Refactored offload_pbo_intra offload_lpa full.

[nj1973]

The new todo list:

• agg_validate.py (?)
• backend_stats.py
• cli_api_nossh.py
• listener_orchestration.py
• offload_backend_part.py
• offload_full.py (we should add a hash partitioned table to this and rename test_offload_full_part.py)
• offload_hash_bucket.py (only need the part of this relating to Synapse hash column)
• offload_subpart.py
• offload_transport.py (only the subpartition split type tests, hopefully these can become unit tests)
• schema_sync.py (?)

[nj1973]

Re-opening for remaining tests to be refactored.

• agg_validate.py (?)
• backend_stats.py
• cli_api_nossh.py
• listener_orchestration.py
• offload_backend_part.py
• schema_sync.py (?)

Raise issue to add a hash partitioned table to test, either to test_offload_misc.py or new test_offload_full_part.py. If latter then move MAXVALUE test there too.