search

gluent / goe

GOE: a simple and flexible way to copy data from an Oracle Database to Google BigQuery.
Apache License 2.0
8 stars 2 forks source link

Clean up redundant offload env variables #6

Closed nj1973 closed 8 months ago

nj1973 commented 11 months ago

Examples I've seen that need to be rectified (there may be others):

For each of these we need to remove any:

abb9979 commented 9 months ago

BigQuery

Common

Hadoop

Snowflake

Synapse

abb9979 commented 8 months ago

I've moved these to issue #15 (data governance):

abb9979 commented 8 months ago

Moved the following to issue #24 (Cloud Sync):

abb9979 commented 8 months ago

Moved the following to issue #10 (Incremental Update):

abb9979 commented 8 months ago

@nj1973 any idea if this is required for orchestration (it's in the offload.env.template.common` file):

# Test condition required for Smart Connector
if [ -z $OFFLOAD_HOME ]; then
      export OFFLOAD_HOME=$(dirname $(dirname $(readlink -f ${BASH_SOURCE[0]})))
fi
abb9979 commented 8 months ago

The following were in the list above but haven't been removed yet because they are still in use:

nj1973 commented 8 months ago

@nj1973 any idea if this is required for orchestration (it's in the offload.env.template.common` file):

# Test condition required for Smart Connector
if [ -z $OFFLOAD_HOME ]; then
      export OFFLOAD_HOME=$(dirname $(dirname $(readlink -f ${BASH_SOURCE[0]})))
fi

I can't think why it would be required for orchestration. I guess it is a nice convenience if we want it:

$ unset OFFLOAD_HOME
$ . /usr/local/goe/offload/conf/offload.env
$ echo $OFFLOAD_HOME
/usr/local/goe/offload

But I always work on the assumption that it is my responsibility to set OFFLOAD_HOME explicitly.

abb9979 commented 8 months ago

Moved the following to issue #20:

abb9979 commented 8 months ago

Moved the following to issue #83: