gluent / goe

GOE: a simple and flexible way to copy data from an Oracle Database to Google BigQuery.
Apache License 2.0
8 stars 2 forks source link

Refactor Offload Status Report #88

Open abb9979 opened 7 months ago

abb9979 commented 7 months ago

Offload Status Report requires refactoring, including:

  1. Making it work with the new GOE structure
  2. Removing many hybrid objects from the reports
  3. Making it work with the GOE repo data, which should simplify data collection
  4. Removing any Gluent-related imaging/badging (see the fake https://goe.com href in the goe_base.html template and related image)
abb9979 commented 7 months ago

Need to add jinja2 to pyproject.toml.

nj1973 commented 6 months ago

When breathing life into OSR we should also remove any references to incremental update and hybrid objects. I've not done these as part of other changes because I am currently unable to run OSR to test my edits.

Also I wonder if _get_demo_table_data should be part of some unit tests and not part of the OSR code?

abb9979 commented 6 months ago

Re: incremental update and hybrid objects. Yes, that will be one of the cleanup tasks.

The original intention behind _get_demo_table_data was to be able to demo OSR to users without needing to hook up a live offload environment. I think it still has its uses, but I agree it's probably better moving to a unit test. As long as we can generate an example for documentation, that should suffice.