Open nj1973 opened 7 months ago
At the start of our entry points we have code to check that OFFLOAD_HOME is set. e.g.:
if not os.environ.get("OFFLOAD_HOME"): print("OFFLOAD_HOME environment variable missing") print("You should source environment variables first, eg: . ../conf/offload.env") sys.exit(1)
This code is duplicated:
./src/goe/config/config_checks.py.check_cli_path()
src/goe/util/misc_functions.py.check_offload_env()
bin/connect
./src/goe/config/config_checks.py.check_cli_path() should be the single point of truth, we should:
check_cli_path()
misc_functions.check_offload_env()
At the start of our entry points we have code to check that OFFLOAD_HOME is set. e.g.:
This code is duplicated:
./src/goe/config/config_checks.py.check_cli_path()
src/goe/util/misc_functions.py.check_offload_env()
bin/connect
./src/goe/config/config_checks.py.check_cli_path()
should be the single point of truth, we should:bin/connect
to usecheck_cli_path()
misc_functions.check_offload_env()
to usecheck_cli_path()
misc_functions.check_offload_env()