gluestack / gluestack-ui

React & React Native Components & Patterns (copy-paste components & patterns crafted with Tailwind CSS (NativeWind))
https://gluestack.io/
MIT License
2.7k stars 120 forks source link

Using `propertyResolver` does not resolve color mode based props #2223

Open xavier-villelegier opened 5 months ago

xavier-villelegier commented 5 months ago

Description

Hey hey ! 👋

I'm trying to have a custom props resolved to a color token depending on the current theme. The props is supposed to be a backgroundStyle object passed down to a library, but for the sake of the example, I simplified it to a simple color props.

As you can see in the example, even if the color mode is dark, the value passed to the propertyResolver is always the default one, never the _dark one. It works fine when not using the resolver, but I'd like to use tokens in there.

Am I missing something ? 👀

CodeSandbox/Snack link

https://snack.expo.dev/1tnf2xC7WhJ6RY0T2-ee7

Steps to reproduce

  1. Go to on the Snack link
  2. See that when using propertyResolver, it never takes into account the _dark selector

gluestack-ui Version

1.1.28

Platform

Other Platform

No response

Additional Information

No response

ankit-tailor commented 4 months ago

Hey @xavier-villelegier, Thanks for reporting the issue. We'll look into it.