gluestack / gluestack-ui

React & React Native Components & Patterns (copy-paste components & patterns crafted with Tailwind CSS (NativeWind))
https://gluestack.io/
MIT License
2.65k stars 118 forks source link

VSCode snippets such as Selection are outdated. #2435

Open Darkiee12 opened 2 months ago

Darkiee12 commented 2 months ago

Description

As the code is updated, it appears the snippets haven't caught up yet.

CodeSandbox/Snack link

https://marketplace.visualstudio.com/items?itemName=gluestack.gluestack-vscode

Steps to reproduce

Install gluestack extension type gs-select-lg (others are also outdated)

<Select size={"lg"} variant={"outline"} isInvalid={false} isDisabled={false}>
  <SelectTrigger size={size} variant={variant}>
    <SelectInput placeholder="Select option" />
    <SelectIcon className="mr-3" as={ChevronDownIcon} />
  </SelectTrigger>
  <SelectPortal>
    <SelectBackdrop />
    <SelectContent>
      <SelectDragIndicatorWrapper>
        <SelectDragIndicator />
      </SelectDragIndicatorWrapper>
      <SelectItem label="UX Research" value="UX Research" />
      <SelectItem label="Web Development" value="Web Development" />
      <SelectItem label="Cross Platform Development Process" value="Cross Platform Development Process" />
      <SelectItem label="UI Designing" value="UI Designing" isDisabled={true} />
      <SelectItem label="Backend Development" value="Backend Development" />
    </SelectContent>
  </SelectPortal>
</Select>;

size={"lg"} and variant={"outline"} are no longer a valid attributes of <Select/> component. Meanwhile it should be <SelectTrigger size={size} variant={variant}> which adopts the correct attribute rather than user input Untitled

gluestack-ui Version

@gluestack-ui/select@0.1.29

Platform

Other Platform

No response

Additional Information

No response

rajat693 commented 1 month ago

Hi @Darkiee12, thank you for bringing this up! This is already in our pipeline, and we’ll be updating it soon.