search

gluethegiant / gtg-rack

Glue the Giant Rack Modules for VCV Rack
GNU General Public License v3.0
25 stars 2 forks source link

Build failure with latest Rack SDK 2.4.0 #13

Closed cschol closed 9 months ago

cschol commented 1 year ago

Rack 2.4.0 now supports theming and there are name clashes with some classes in the SDK:

In file included from src/Road.cpp:2:                                                                                                                      
src/gtgComponents.hpp:332:21: error: reference to 'ThemedSvgPort' is ambiguous                                                                             
struct gtgNutPort : ThemedSvgPort {                                                                                                                        
                    ^                                                                                                                                      
src/gtgComponents.hpp:64:8: note: candidate found by name lookup is 'ThemedSvgPort'                                                                        
struct ThemedSvgPort : SvgPort {                                                                                                                                                                                                                                                                                       
       ^                                                                                                                                                   
/home/build/rack-plugin-toolchain/Rack-SDK-mac-x64/include/app/SvgPort.hpp:30:8: note: candidate found by name lookup is 'rack::app::ThemedSvgPort'        
struct ThemedSvgPort : SvgPort {                                                                                                                                                                                                                                                                                       
       ^
gluethegiant commented 1 year ago

Thank you cschol, I'll work on an update for the new SDK and resubmit.

baconpaul commented 10 months ago

Hi @gluethegiant hope you dont mind. Was scanning the build updates now @cschol is doing integration again and saw this as a stuck one. Was a 3 minute fix with the clion refactoring tool so pushed a PR up with #15.

baconpaul commented 10 months ago

Turns out this is already on the development branch at https://github.com/gluethegiant/gtg-rack/commit/7e20713eacc51179cd7faf0f4428def2b82273a9

so i really think this is just move dev -> main, update the json version, submit, and voila. I closed my PR as a result. (And thanks for pointing it out @SteveRussell33)

gluethegiant commented 9 months ago

Renamed components, bumped json version, and merged development branch into master.