Added projects & members

glugnith / glug.nith.ac.in

GLUG-NITH website source code :penguin: *DEPRECATED*

8 stars 52 forks source link

Closed kumarmj closed 9 years ago

kumarmj commented 9 years ago

for members used index.php style but removed twitter. Just added link of projects.php

pranavk commented 9 years ago

Good work overall !

Few comments -

You need to squash the last two commits.
As of now, I think it would be better to hide the projects link from glugnith homepage because there is nothing relevant there at the moment.
Fix the commit message, spelling typo there, it says 'extraa'. s/extraa/extra/

pranavk commented 9 years ago

I don't have any problem with projects page shown up in the website, but there is nothing in there but few broken links.

@rohanjaswal2507 Was it decided in the meeting to show the project page anyways ?

pranavk commented 9 years ago

One more thing

Good, but seems you and @lokeshh are working on same thing. It would be better to work on two separate things in future.

kumarmj commented 9 years ago

Squashed the commits. @sagarkarira Sir said for projects link.

rohanjaswal2507 commented 9 years ago

@nithmanoj Why did you remove tweets from index.php?

kumarmj commented 9 years ago

I removed that from members.php , As it is bottom of page & table was long. If by chance it got removed from index.php that's mistake

kumarmj commented 9 years ago

I removed that from members.php , As it is bottom of page & table was long. If by chance it got removed from index.php that's mistake

rohanjaswal2507 commented 9 years ago

@nithmanoj please revert the changes you made to index.php. We need tweets there.

kumarmj commented 9 years ago

Sir added tweets. Sorry for that mistake...

pranavk commented 9 years ago

Please don't include projects page as of now, since we don't have any projects to showcase as of this writing.

@nithmanoj Also, since it was a mistake on your behalf, deleting tweets, squash this into your previous commit.

pranavk commented 9 years ago

So, just adding a commit adding the members page should do fine. Please submit a new PR adding the members page only.