search

glugnith / glug.nith.ac.in

GLUG-NITH website source code :penguin: *DEPRECATED*
8 stars 52 forks source link

HTML5 ready #7

Closed divyanshu013 closed 10 years ago

divyanshu013 commented 10 years ago

Tried to make the website html5 ready for html5 support and latest tags

pranavk commented 10 years ago

Hello divyanshu,

Thanks for your patch. There are few comments I would like to make.

  1. There is no need for the "Merge Pull request .." commit to be included in pull request. That should also not be a commit in your local branch too.
  2. The commit messages are not very elegant. Basically the first line should be a commit message heading followed by a description of the commit after leaving one blank line. I edited the commit messages myself, so you can have a look what I am expecting from you.
pranavk commented 10 years ago

I am closing this request. Clean things up and do it again.