search

gluon-framework / gluon

A new framework for creating desktop apps from websites, using system installed browsers and NodeJS
https://gluonjs.org
MIT License
3.1k stars 76 forks source link

typedef: properly set default value for useSessionId #34

Closed smartfrigde closed 1 year ago

smartfrigde commented 1 year ago

https://tsdoc.org/pages/tags/defaultvalue/ If this is not applied, tsc fails with these errors:

node_modules/.pnpm/github.com+gluon-framework+gluon@b589fb3e8c7c39bd77961dec8c04f61f35850761/node_modules/@gluon-framework/gluon/gluon.d.ts:120:5 - error TS1015: Parameter cannot have question mark and initializer.

120     useSessionId?: Boolean = true
        ~~~~~~~~~~~~

node_modules/.pnpm/github.com+gluon-framework+gluon@b589fb3e8c7c39bd77961dec8c04f61f35850761/node_modules/@gluon-framework/gluon/gluon.d.ts:120:5 - error TS2371: A parameter initializer is only allowed in a function or constructor implementation.

120     useSessionId?: Boolean = true
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 2 errors in the same file, starting at: node_modules/.pnpm/github.com+gluon-framework+gluon@b589fb3e8c7c39bd77961dec8c04f61f35850761/node_modules/@gluon-framework/gluon/gluon.d.ts:120