search

gluon-framework / gluon

A new framework for creating desktop apps from websites, using system installed browsers and NodeJS
https://gluonjs.org
MIT License
3.1k stars 76 forks source link

Chrome allow components flag #71

Closed popaprozac closed 1 year ago

popaprozac commented 1 year ago

Allowing components enables a wide range of capabilities that you may want your app to have such as Widevine for DRM content on macOS/Windows (presumably Linux? need to test)

On Linux, Chromium was happy if you plunk the WidevineCdm in gluon_data. On macOS/Windows this is not the case.

popaprozac commented 1 year ago

I can update the docs if this is merged

CanadaHonk commented 1 year ago

It would probably be better to just replace the --disable-component-update flag with --component-updater=url-source=http://localhost:0, instead of having a flag.

popaprozac commented 1 year ago

Fair! I'll update the PR.

My rationale was if you had Chrome components installed for your day to day use that you do not want to load in a Gluon app.

CanadaHonk commented 1 year ago

Fair enough, just components aren't really used like that (often at least) afaik.

popaprozac commented 1 year ago

If this is a problem down the road it's easy enough to change. PR changes incoming soon.

Thanks!

popaprozac commented 1 year ago

Huh? Git... Let me resubmit