gluon / AbletonLive9_RemoteScripts

Unofficial repository for Ableton Live 9 MIDI Remote Scripts by Julien Bayle
http://julienbayle.net/ableton-live-9-midi-remote-scripts/
513 stars 245 forks source link

Systematic decompilation bug in _Framework? #37

Open bolau opened 8 years ago

bolau commented 8 years ago

Hi Julien,

first of all - thank you so much for your work on the remote scripts, this is incredible!

I think I've found a systematic bug in the decompilations of _Framework related to Assertions. For example: _Framework/MixerComponent.py:268 The lines below "raise AssertionError" should most probably be unintented one step, otherwise that code is never executed:

if not self._bank_up_button != None: raise AssertionError if self.is_enabled(): <<<<<< needs unintent? new_offset = (value is not 0 or not ...

This seems to occur wherever a raise follows an if. I guess this is not critical, since nobody will ever execute this. But it's confusing when trying to understand how the stuff works...