gluonhq / attach

GNU General Public License v3.0
49 stars 26 forks source link

com.gluonhq.attach.position.Parameters has a bad constructor #311

Open nlisker opened 2 years ago

nlisker commented 2 years ago

The Accuracy enum encapsulates predefined distance and time filters. Parameters can either take an Parameters (which it does), or take custom time and distance parameters. The problem is that there is a constructor that takes both an accuracy and time and distance parameters, making the accuracy meaningless.

I think that this constructor should be deprecated in favor of a (time, distance, background) constructor. getAccuracy() will return null in this case.