gluonhq / attach

GNU General Public License v3.0
49 stars 26 forks source link

removed blocking calls #324

Closed molbertz closed 2 years ago

molbertz commented 2 years ago

These are the changes which now only have non blocking calls. But maybe we should re-add the blocking ones as deprecated to not break the API.

jperedadnr commented 2 years ago

Great, looks good. Just realised there is one final thing left to do: can you please update also the sample snippet in the javadoc?

Something like:

 * <pre>
 * {@code BarcodeScanService.create().ifPresent(service -> {
 *      service.resultProperty().addListener((obs, ov, nv) ->
 *          System.out.printf("Scanned result: %s", nv.getResult()));
 *      barcodeScanService.asyncScan();
 *  });}</pre>
molbertz commented 2 years ago

Oh yes, that makes sense. Do you want to replace the deprecated example or keep it?

jperedadnr commented 2 years ago

No, just remove it