search

gluonhq / attach

GNU General Public License v3.0
50 stars 26 forks source link

Please add AudioService support for iOS #345

Closed salmonb closed 1 year ago

salmonb commented 1 year ago

Hi,

I have a couple of Gluon apps playing music that work fine on Android, but not on iOS.

On iOS there is no sound, and I'm getting the following log:

[Mon Jan 30 08:54:03 GMT 2023][INFO] [SUB] Jan 30, 2023 8:53:54 AM com.gluonhq.attach.util.impl.DefaultServiceFactory createInstance
[Mon Jan 30 08:54:03 GMT 2023][INFO] [SUB] WARNING: No new instance for interface com.gluonhq.attach.audio.AudioService and class com.gluonhq.attach.audio.impl.IOSAudioService

So it looks like the AudioService implementation for iOS is expected to be com.gluonhq.attach.audio.impl.IOSAudioService but this class actually doesn't exist in Gluon Attach...

Could you implement this class please?

salmonb commented 1 year ago

I actually implemented it!

Can you please merge my PR?

jperedadnr commented 1 year ago

Fixed with #347