search

gluonhq / attach

GNU General Public License v3.0
48 stars 26 forks source link

add bt scan permission to manifest and init routine of DalvikBleService #351

Closed macgibbon closed 1 year ago

macgibbon commented 1 year ago

Android API level 3 has a new permission for BLE peripherals as described here.

jperedadnr commented 1 year ago

I take that you mean Android 31+ ?

In that case, shouldn't we add a check on the version and only apply the changes to

Can you update the copyright year to 2023, and sign the CLA if you haven't done it yet?

jperedadnr commented 1 year ago

@macgibbon are you willing to address the feedback? In case that you can't, no problem, I'll do a PR myself with the required changes, in order to fix this issue and release Attach 4.0.18 with this and the recent changes needed for Android 31

jperedadnr commented 1 year ago

closed by #357

macgibbon commented 11 months ago

I apologize for not addressing the feedback, I didn't have notifications set up properly and sort of moved on to other activities with the onset of good weather. Thanks for implementing the fixes!