search

gluonhq / attach

GNU General Public License v3.0
48 stars 26 forks source link

Bump Android SDK to 34 #395

Closed jperedadnr closed 1 month ago

jperedadnr commented 1 month ago

Fixes #394

abhinayagarwal commented 1 month ago

Tested. Without platform 34, build fails with:

Error: path for /Users/abhinay/Documents/software/android/platforms/android-34/android.jar doesn't exist

After install platform 34, Gradle automatically installed v34.0.0 and build succeeded installing all the modules successfully.

Does this need any change in the Github Action workflow?

jperedadnr commented 1 month ago

Right, Attach doesn't install the SDK, but it can be done with Substrate/GluonFX though including https://github.com/gluonhq/substrate/pull/1251