search

gluonhq / client-samples

Client samples to run with Gluon Client plugins for Maven and Gradle
114 stars 23 forks source link

Currently the native image build does not support JPMS #28

Closed joerg-wille closed 4 years ago

jperedadnr commented 4 years ago

Hi @joerg-wille, thanks for your contribution. The issue has been already fixed and the next plugin version will allow a mainclassName parameter with a module name prefix. However in the meantime we need a fix like the one you have proposed. Please sign the CLA so we can proceed and merge your PR. Thanks

joerg-wille commented 4 years ago

Hi José, cool, did not know about the CLA - just signed. Great to hear that this will be fixed in the plugin. I was just amazed that all the samples and even a current - small - UI from myself worked out of the box. (I mean except from this module name.) I thought maybe would get an even more perfect experience ;-)

Really looking forward to all the mobile things you guys are planning - especially Android :-)

Best regards

Am Fr., 22. Nov. 2019 um 17:30 Uhr schrieb José Pereda < notifications@github.com>:

Hi @joerg-wille https://github.com/joerg-wille, thanks for your contribution. The issue has been already fixed and the next plugin version will allow a mainclassName parameter with a module name prefix. However in the meantime we need a fix like the one you have proposed. Please sign the CLA https://github.com/gluonhq/client-samples#issues-and-contributions so we can proceed and merge your PR. Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gluonhq/client-samples/pull/28?email_source=notifications&email_token=ADAGULWD5APCSOZPL452G4LQVACJBA5CNFSM4JQJBLFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE6E4JQ#issuecomment-557600294, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADAGULQ7O6BEIMQ25G6EFVTQVACJBANCNFSM4JQJBLFA .

jperedadnr commented 4 years ago

Thanks for testing, and keep feedback coming! Android support is starting (check for instance this PR).