search

gluonhq / maps

https://gluonhq.com/labs/maps/
GNU General Public License v3.0
141 stars 35 forks source link

Add TileImageView to manage the async download of tiles #48

Closed jperedadnr closed 3 years ago

jperedadnr commented 4 years ago

Fixes #47

jperedadnr commented 4 years ago

@eugener I've quickly applied AutoCloseable, but that didn't seem to help. Each TileImageView will need its own Executor in order to shut it down when the tile is not longer in the scene? On a different approach, I've applied successfully this option. It uses a DaemonThreadFactory, so the Executor now will create daemon threads, and the app will successfully exit.

eugener commented 4 years ago

Ah...This should work too. But it is not part of this PR yet?

jperedadnr commented 4 years ago

No, not yet, I tested it, and I was running it by you first before pushing it :)

jperedadnr commented 4 years ago

I've added now the DaemonThreadFactory class