search

gluonhq / maps

https://gluonhq.com/labs/maps/
GNU General Public License v3.0
137 stars 34 forks source link

Osm license #52

Open brunesto opened 3 years ago

brunesto commented 3 years ago

Hello this is to resolve #51 - the osm tile usage policy . it does not remove the app, just adds copyright label and changes the way TileRetriever is instanciated

Adding the copyright label is just a couple of lines in MapView

For beeing able to easily use own tile provider (e.g. in the MobileSample class) it required more changes: Basically TileProviderRetriever is gone, instead the TileRetriever has to passed as a constructor arg to MapView and BaseMap. Hence CachedOsmTileRetriever does not have static fields methods anymore.

I wanted to keep the changes small, so 2 further changes are probably needed:

abhinayagarwal commented 3 years ago

Hi @brunesto ,

Thank you for the PR. Please sign the Gluon CLA as per the Gluon contribution requirement.

jperedadnr commented 3 years ago

@brunesto We have just merged a pending PR, can you fix the conflicts?

brunesto commented 3 years ago

@jperedadnr I think it's done