search

gluonhq / maps

https://gluonhq.com/labs/maps/
GNU General Public License v3.0
137 stars 34 forks source link

Rewrite CachedOsmTileRetriever #53

Open abhinayagarwal opened 3 years ago

abhinayagarwal commented 3 years ago

CachedOsmTileRetriever has multiple issues:

  1. CacheThread has an indefinite while loop. The deactivate() which is supposed to break the while loop is never called.
  2. In #52, CachedOsmTileRetriever is being updated to a non-static class. This will lead to having different instances of CacheThread writing to the same cache directory. If the PR is merged, this needs to be fixed as well.