gluon-bot commented 7 years ago

Originally reported by: A. Walter (Bitbucket: awalterwork, GitHub: Unknown)

In SceneBuilder 8.3.0, when using multiple fx:reference blocks to refer to objects defined in fx:define blocks, sometimes (see below) you

cannot see edits you make to the FXML (they don't show up in the FXML file view in the center)
cannot do a normal save (Ctrl+S doesn't seem to do anything and the Save item in the File menu is greyed out).

I say "sometimes", because I found some scenarios where everything works fine and some very similar scenarios where the weird behaviour described above occurs. I'm not sure what exactly causes the different behaviour, but it is reproducable.

Steps to reproduce

Open any of the attached files called NotWorking_.fxml in SceneBuilder.
Try to edit the text of the button that says "Change my Text!" (change the text, hit Enter). The FXML file view in the center is not updated.
Try to save with Ctrl+S (nothing happens) or via the File menu (not possible).
Use Save As... and choose the the file you are currently editing. This updates the file in the file system, but the FXML file view in the center of SB is not updated. You still cannot save normally.
Open any of the attached files called Working_.fxml in SceneBuilder.
Edit the text of the button that says "Change my Text!" (change the text, hit Enter). The FXML file view in the center is updated.
Save with Ctrl+S or via the File menu (enabled).
(Note that all fx:references are removed on save - this behaviour is wrong and documented in bug #121 .)

The scenarios that work and do not work are very similar - see some snippets:

NotWorking1.fxml

#!xml

<BorderPane prefHeight="200" prefWidth="500" xmlns="http://javafx.com/javafx/8.0.101" xmlns:fx="http://javafx.com/fxml/1">
    <fx:define>
        <Button fx:id="define1" text="fx:define Btn 1" />
        <Button fx:id="define2" text="fx:define Btn 2" />
    </fx:define>
    <top>
        <fx:reference source="define1" />
    </top>
    <center>
        <VBox>
            <fx:reference source="define2" />
            <Button text="Change my Text!" />
        </VBox>
    </center>
</BorderPane>

NotWorking2.fxml

#!xml

<BorderPane prefHeight="200" prefWidth="500" xmlns="http://javafx.com/javafx/8.0.101" xmlns:fx="http://javafx.com/fxml/1">
    <fx:define>
        <Button fx:id="define1" text="fx:define Btn 1" />
        <Button fx:id="define2" text="fx:define Btn 2" />
    </fx:define>
    <center>
        <VBox>
            <Button text="Change my Text!" />
            <fx:reference source="define1" />
            <fx:reference source="define2" />
        </VBox>
    </center>
</BorderPane>

NotWorking3.fxml

#!xml

<BorderPane prefHeight="200" prefWidth="500" xmlns="http://javafx.com/javafx/8.0.101" xmlns:fx="http://javafx.com/fxml/1">
    <fx:define>
        <Button fx:id="define1" text="fx:define Btn 1" />
        <Button fx:id="define2" text="fx:define Btn 2" />
    </fx:define>
    <top>
        <Button text="Change my Text!" />
    </top>
    <center>
        <VBox>
            <fx:reference source="define1" />
            <fx:reference source="define2" />
        </VBox>
    </center>
</BorderPane>

Working1.fxml (identical to NotWorking1.fxml except for button order in VBox)

#!xml

<BorderPane prefHeight="200" prefWidth="500" xmlns="http://javafx.com/javafx/8.0.101" xmlns:fx="http://javafx.com/fxml/1">
    <fx:define>
        <Button fx:id="define1" text="fx:define Btn 1" />
        <Button fx:id="define2" text="fx:define Btn 2" />
    </fx:define>
    <top>
        <fx:reference source="define1" />
    </top>
    <center>
        <VBox>
            <Button text="Change my Text!" />
            <fx:reference source="define2" />
        </VBox>
    </center>
</BorderPane>

Working2.fxml

#!xml

<BorderPane prefHeight="200" prefWidth="500" xmlns="http://javafx.com/javafx/8.0.101" xmlns:fx="http://javafx.com/fxml/1">
    <fx:define>
        <Button fx:id="define1" text="fx:define Btn 1" />
        <Button fx:id="define2" text="fx:define Btn 2" />
    </fx:define>
    <top>
        <fx:reference source="define1" />
    </top>
    <center>
        <VBox>
            <Button text="Change my Text!" />
        </VBox>
    </center>
    <left>
        <fx:reference source="define2" />
    </left>
</BorderPane>

Expected behaviour

Edits should always show up and normal saving should be possible when multiple fx:reference blocks are used, regardless of where exactly they are used.
(Also, the fx:references should not be deleted on save - see bug #121 ).

Bitbucket: https://bitbucket.org/gluon-oss/scenebuilder/issue/123

abhinayagarwal commented 3 years ago

Related to #121

Oliver-Loeffler commented 2 years ago

Hi @abhinayagarwal, I will look into this and see if the problem still exists. If so, I'll try to build up understanding and share this here.

gluonhq / scenebuilder

Cannot see edits or do a normal save when multiple fx:reference blocks are used (sometimes) #123