gluonhq / scenebuilder

Scene Builder is a visual, drag 'n' drop, layout tool for designing JavaFX application user interfaces.
https://gluonhq.com/products/scene-builder/
Other
728 stars 218 forks source link

SceneBuilder Kit crippled by Gluon Charm hidden dependency #128

Open gluon-bot opened 7 years ago

gluon-bot commented 7 years ago

Originally reported by: Adam Walczak (Bitbucket: walec51, GitHub: walec51)


How are we supposed to use it if it has hidden dependencies to your closed source libraries?

https://bitbucket.org/gluon-oss/scenebuilder/src/ef68e38ec2422a66f71f3922b5aa83a5ece1aa84/src/main/java/com/oracle/javafx/scenebuilder/kit/library/BuiltinLibrary.java?at=default&fileviewer=file-view-default#BuiltinLibrary.java-122

This end with:

java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at com.sun.javafx.application.LauncherImpl.launchApplicationWithArgs(LauncherImpl.java:389) at com.sun.javafx.application.LauncherImpl.launchApplication(LauncherImpl.java:328) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at sun.launcher.LauncherHelper$FXHelper.main(LauncherHelper.java:767) Caused by: java.lang.RuntimeException: Exception in Application start method at com.sun.javafx.application.LauncherImpl.launchApplication1(LauncherImpl.java:917) at com.sun.javafx.application.LauncherImpl.lambda$launchApplication$99(LauncherImpl.java:182) at java.lang.Thread.run(Thread.java:745) Caused by: java.lang.NoClassDefFoundError: com/gluonhq/charm/glisten/control/AppBar at com.oracle.javafx.scenebuilder.kit.library.BuiltinLibrary.(BuiltinLibrary.java:124) at com.oracle.javafx.scenebuilder.kit.library.BuiltinLibrary.getLibrary(BuiltinLibrary.java:88) at com.oracle.javafx.scenebuilder.kit.editor.EditorController.(EditorController.java:256) at designerexperiment.DesignerExperiment.start(DesignerExperiment.java:27) at com.sun.javafx.application.LauncherImpl.lambda$launchApplication1$106(LauncherImpl.java:863) at com.sun.javafx.application.PlatformImpl.lambda$runAndWait$119(PlatformImpl.java:326) at com.sun.javafx.application.PlatformImpl.lambda$null$117(PlatformImpl.java:295) at java.security.AccessController.doPrivileged(Native Method) at com.sun.javafx.application.PlatformImpl.lambda$runLater$118(PlatformImpl.java:294) at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95) at com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method) at com.sun.glass.ui.gtk.GtkApplication.lambda$null$450(GtkApplication.java:139) ... 1 more Caused by: java.lang.ClassNotFoundException: com.gluonhq.charm.glisten.control.AppBar at java.net.URLClassLoader.findClass(URLClassLoader.java:381) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ... 13 more


gluon-bot commented 7 years ago

Original comment by Adam Walczak (Bitbucket: walec51, GitHub: walec51):


Plus you added a cyclic dependency from the kit package to the app package...

https://bitbucket.org/gluon-oss/scenebuilder/commits/44a2d53fbd4c7f5f35e7412c9f2b18fa1d06d3c5#Lsrc/main/java/com/oracle/javafx/scenebuilder/kit/editor/panel/content/WorkspaceController.javaT161