search

gluonhq / scenebuilder

Scene Builder is a visual, drag 'n' drop, layout tool for designing JavaFX application user interfaces.
https://gluonhq.com/products/scene-builder/
Other
737 stars 219 forks source link

Version 18.0.0 bug. #553

Open pnahay opened 2 years ago

pnahay commented 2 years ago

Product Version JavaFX Scene Builder 18.0.0

Build Information Version 18.0.0 Date: 2022-03-31 20:20:30 JavaFX Version: 18 Java Version: 17, OpenJDK Runtime Environment

Expected Behavior

Ctrl+P should invoke menu command "Show Preview in Window".

Current Behavior

Ctrl+P does nothing.

Steps to Reproduce

Invoke Ctrl+P.

Your Environment

Windows 10.

Screenshots

Oliver-Loeffler commented 2 years ago

Hi @pnahay , I've tested it with current Scene Builder 19 Snapshot version on Win10 21H2 and also with the SB18 version as released before April. In both cases I was unfortunately not able to reproduce the isse.

Can you please share more details? Did you install from MSI file, did you ran Scene Builder from project?

pnahay commented 2 years ago

I’ve discovered that the problem occurs on some files and not others.

I’m sorry, but I’m not at liberty to share the .fxml files with you that prove this.

So it appears to be a problem associated with something in the particular .fxml file loaded.

Hope that helps.

Paul

From: Oliver Löffler @.*** Sent: Saturday, October 1, 2022 10:24 AM To: gluonhq/scenebuilder Cc: pnahay; Mention Subject: Re: [gluonhq/scenebuilder] Version 18.0.0 bug. (Issue #553)

Hi @pnahay https://github.com/pnahay , I've tested it with current Scene Builder 19 Snapshot version on Win10 21H2 and also with the SB18 version as released before April. In both cases I was unfortunately not able to reproduce the isse.

Can you please share more details? Did you install from MSI file, did you ran Scene Builder from project?

— Reply to this email directly, view it on GitHub https://github.com/gluonhq/scenebuilder/issues/553#issuecomment-1264380852 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AADX6E4R3MTTTFQQALSMJOTWBBCQNANCNFSM5STW27VQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AADX6E2U75S65S7RTCYD3LDWBBCQNA5CNFSM5STW27V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJNOOXNA.gif Message ID: @.***>

Oliver-Loeffler commented 2 years ago

Hi @pnahay, this helps a little. Well, there is no need to share the original file. If you could create another FXML file with a structrue which also creates the behavior, that would help a lot.

If you are using some kind of dynamic elements or custom values or includes inside the FXML, try to replace them with artificial content not related to the issue. An example showing the behavior would be great. One approach would be to take a working example and modify it step by step to reach the point where Scene Builder breaks or vice versa by taking content away from the questinable FXML until Scene Builder starts to work.

From that on, I would be able to create a test and possibly find a solution.

pnahay commented 2 years ago

this helps a little. Well, there is no need to share the original file. If you could create another FXML file with a structrue which also creates the behavior, that would help a lot.

OK, I’ll see if I can remove the “private” stuff and leave 2 files that show the difference.

If you are using some kind of dynamic elements or custom values or includes inside the FXML, try to replace them with artificial content not related to the issue.

No, I’m not doing anything fancy with the fxml, just letting SB generate it, then reading it into my JavaFX program.

An example showing the behavior would be great. One approach would be to take a working example and modify it step by step to reach the point where Scene Builder breaks or vice versa by taking content away from the questinable FXML until Scene Builder starts to work.

I’ll see what I can do, although my time is limited.

From that on, I would be able to create a test and possibly find a solution.

OK, I will try to get you something in the next day or so.

Paul

pnahay commented 2 years ago

OK, here you go:

Product Version

JavaFX Scene Builder 18.0.0

Attached are two FXML files.

I can open File1.fxml in SB, and IMMEDIATELY press Ctrl+P to get the preview of the window.

But when I open File2.fxml in SB, I cannot access/use Ctrl+P at all, I have to open the SB “Preview” menu and invoke the command from there.

Hope you can figure out what the deal is.

Paul

P.S. A particularly bad “feature” of SB is that if it thinks the XML is malformed, it doesn’t tell you what is wrong, it just tells you something is wrong, which is useless.

From: Oliver Löffler @.*** Sent: Saturday, October 1, 2022 3:49 PM To: gluonhq/scenebuilder Cc: pnahay; Mention Subject: Re: [gluonhq/scenebuilder] Version 18.0.0 bug. (Issue #553)

Hi @pnahay https://github.com/pnahay , this helps a little. Well, there is no need to share the original file. If you could create another FXML file with a structrue which also creates the behavior, that would help a lot.

If you are using some kind of dynamic elements or custom values or includes inside the FXML, try to replace them with artificial content not related to the issue. An example showing the behavior would be great. One approach would be to take a working example and modify it step by step to reach the point where Scene Builder breaks or vice versa by taking content away from the questinable FXML until Scene Builder starts to work.

From that on, I would be able to create a test and possibly find a solution.

— Reply to this email directly, view it on GitHub https://github.com/gluonhq/scenebuilder/issues/553#issuecomment-1264463373 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AADX6E2RTT6EVTMN7WBWBSLWBCISTANCNFSM5STW27VQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AADX6E6I32WDGQA5RGX74QLWBCISTA5CNFSM5STW27V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJNPC4DI.gif Message ID: @.***>

pnahay commented 2 years ago

Sorry, goofed on one file, here’s File1 again, replaces previous one.

From: Paul Nahay @. Sent: Saturday, October 1, 2022 5:09 PM To: 'gluonhq/scenebuilder'; 'gluonhq/scenebuilder' Cc: 'Mention'; @. Subject: RE: [gluonhq/scenebuilder] Version 18.0.0 bug. (Issue #553)

OK, here you go:

Product Version

JavaFX Scene Builder 18.0.0

Attached are two FXML files.

I can open File1.fxml in SB, and IMMEDIATELY press Ctrl+P to get the preview of the window.

But when I open File2.fxml in SB, I cannot access/use Ctrl+P at all, I have to open the SB “Preview” menu and invoke the command from there.

Hope you can figure out what the deal is.

Paul

P.S. A particularly bad “feature” of SB is that if it thinks the XML is malformed, it doesn’t tell you what is wrong, it just tells you something is wrong, which is useless.

From: Oliver Löffler @.*** Sent: Saturday, October 1, 2022 3:49 PM To: gluonhq/scenebuilder Cc: pnahay; Mention Subject: Re: [gluonhq/scenebuilder] Version 18.0.0 bug. (Issue #553)

Hi @pnahay https://github.com/pnahay , this helps a little. Well, there is no need to share the original file. If you could create another FXML file with a structrue which also creates the behavior, that would help a lot.

If you are using some kind of dynamic elements or custom values or includes inside the FXML, try to replace them with artificial content not related to the issue. An example showing the behavior would be great. One approach would be to take a working example and modify it step by step to reach the point where Scene Builder breaks or vice versa by taking content away from the questinable FXML until Scene Builder starts to work.

From that on, I would be able to create a test and possibly find a solution.

— Reply to this email directly, view it on GitHub https://github.com/gluonhq/scenebuilder/issues/553#issuecomment-1264463373 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AADX6E2RTT6EVTMN7WBWBSLWBCISTANCNFSM5STW27VQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AADX6E6I32WDGQA5RGX74QLWBCISTA5CNFSM5STW27V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJNPC4DI.gif Message ID: @.***>

Oliver-Loeffler commented 2 years ago

Hi Paul, thanks! Please add the file to the issue - seems that E-Mail attachments are not added to Github issues.

Thanks! Oliver

Oliver-Loeffler commented 2 years ago

You can paste the FXML contents into a codeblock such as this one:

<FXML>
some contents...
</FXML>

Like that.

Oliver-Loeffler commented 2 years ago

Thanks for your support @pnahay , but those files did not arrive. Please just share the FXML #2 code here as plain text. This will be sufficient! Great weekend!

Oliver-Loeffler commented 2 years ago

Hi @pnahay thanks for putting efforts into making this reproducible. Can you please post the result of your investigations? Would be great to have the FXML #2 for testing. Otherwise, can you please describe what is different between the good and the failing FXML?

Thanks!

pnahay commented 2 years ago

The failing one, when loaded in SB, causes SB to not respond to the CTRL+P accelerator.

From: Oliver Löffler @.*** Sent: Sunday, October 9, 2022 3:10 PM To: gluonhq/scenebuilder Cc: pnahay; Mention Subject: Re: [gluonhq/scenebuilder] Version 18.0.0 bug. (Issue #553)

Hi @pnahay https://github.com/pnahay thanks for putting efforts into making this reproducible. Can you please post the result of your investigations? Would be great to have the FXML #2 https://github.com/gluonhq/scenebuilder/issues/2 for testing. Otherwise, can you please describe what is different between the good and the failing FXML?

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/gluonhq/scenebuilder/issues/553#issuecomment-1272609231 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AADX6E254MQI7DY6KQSCYX3WCMKA7ANCNFSM5STW27VQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AADX6E4IQ6ETT26TCSCKHP3WCMKA7A5CNFSM5STW27V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJPNHTTY.gif Message ID: @.***>

Oliver-Loeffler commented 2 years ago

Sorry. Well, I was more thinking on what the difference is inside the FXML, so the FXML code difference. The FXML examples you've prepared are not accessible here. Could you please attach those example files here? Either FXML code directly or via link to e.g. pastebin.

pnahay commented 2 years ago

Sorry. Well, I was more thinking on what the difference is inside the FXML, so the FXML code difference.

There’s no releationship between them. My point with the other one was just to tell you that CTRL+P DOES work for me with other files. So, you can compare my one I sent you that doesn’t work with any that YOU create that DO work.

The difference between a “file that works” and a “file that doesn’t work” is for the programmers who wrote SB to figure out, not me.

The FXML examples you've prepared are not accessible here. Could you please attach those example files here? Either FXML code directly or via link to e.g. pastebin.

I don’t understand. You write:

  1. The FXML examples you've prepared are not accessible here.

  2. Could you please attach those example files here?

So, 2 sentences, each of which refer to “here”, one of which says “here” works, and one of which says “here” doesn’t work.

I had attached the files for you. You’re asking me to attach them again?

File that “doesn’t work” is attached again.

Paul

Oliver-Loeffler commented 2 years ago

It seems if you just reply vie e-mail, the files are not attached to the Github issue. If you visit the Github website, navigate to the issue, then you can attach these files. With 'here' I am referring the Github Issue website at https://github.com/gluonhq/scenebuilder/issues/553.

pnahay commented 2 years ago

I’m on the #553 GitHub page, but don’t see anything that lets me attach a file.

From: Oliver Löffler @.*** Sent: Sunday, October 9, 2022 6:14 PM To: gluonhq/scenebuilder Cc: pnahay; Mention Subject: Re: [gluonhq/scenebuilder] Version 18.0.0 bug. (Issue #553)

It seems if you just reply vie e-mail, the files are not attached to the Github issue. If you visit the Github website, navigate to the issue, then you can attach these files. With 'here' I am referring the Github Issue website at #553 https://github.com/gluonhq/scenebuilder/issues/553

— Reply to this email directly, view it on GitHub https://github.com/gluonhq/scenebuilder/issues/553#issuecomment-1272639203 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AADX6E3MDEMVMEJ5JHRMESLWCM7TFANCNFSM5STW27VQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AADX6E7UQK2D5MVVJOVDEGLWCM7TFA5CNFSM5STW27V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJPNO5YY.gif Message ID: @.***>

pnahay commented 2 years ago

OK, I logged in and now see it.

But your silly system won’t let me attach an FXML file, the page source says:

We don’t support that file type.

Try again with a GIF, JPEG, JPG, MOV, MP4, PNG, SVG, WEBM, CSV, DOCX, FODG, FODP, FODS, FODT, GZ, LOG, MD, ODF, ODG, ODP, ODS, ODT, PDF, PPTX, TGZ, TXT, XLS, XLSX or ZIP.

From: Paul Nahay @.*** Sent: Sunday, October 9, 2022 6:42 PM To: 'gluonhq/scenebuilder'; 'gluonhq/scenebuilder' Cc: 'Mention' Subject: RE: [gluonhq/scenebuilder] Version 18.0.0 bug. (Issue #553)

I’m on the #553 GitHub page, but don’t see anything that lets me attach a file.

From: Oliver Löffler @.*** Sent: Sunday, October 9, 2022 6:14 PM To: gluonhq/scenebuilder Cc: pnahay; Mention Subject: Re: [gluonhq/scenebuilder] Version 18.0.0 bug. (Issue #553)

It seems if you just reply vie e-mail, the files are not attached to the Github issue. If you visit the Github website, navigate to the issue, then you can attach these files. With 'here' I am referring the Github Issue website at #553 https://github.com/gluonhq/scenebuilder/issues/553

— Reply to this email directly, view it on GitHub https://github.com/gluonhq/scenebuilder/issues/553#issuecomment-1272639203 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AADX6E3MDEMVMEJ5JHRMESLWCM7TFANCNFSM5STW27VQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AADX6E7UQK2D5MVVJOVDEGLWCM7TFA5CNFSM5STW27V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJPNO5YY.gif Message ID: @.***>

pnahay commented 2 years ago

Your ridiculous system won't allow me to attach an fxml file, so here's the content of the file that, when opened in SceneBuilder, won't allow the CTRL+P accelerator key combination to preview the file:

<GridPane alignment="CENTER" hgap="11.0" vgap="20.0" VBox.vgrow="NEVER">
    <columnConstraints>
        <ColumnConstraints halignment="RIGHT" maxWidth="541.0" minWidth="10.0" prefWidth="211.0" />
        <ColumnConstraints halignment="LEFT" maxWidth="867.0" minWidth="10.0" prefWidth="867.0" />
    </columnConstraints>
    <children>

        <Label styleClass="bbdlabel" stylesheets="@styles.css" text="ppppp ccccc:" GridPane.columnIndex="0" GridPane.rowIndex="0" />
        <Label fx:id="labelpppppccccc" contentDisplay="CENTER" prefHeight="57.0" prefWidth="875.0" styleClass="status" stylesheets="@styles.css" text="&lt;ppppp ccccc&gt;" GridPane.columnIndex="1" GridPane.rowIndex="0" />
        <!-- -->                        

        <Label styleClass="bbdlabel" stylesheets="@styles.css" text="mmmm ppppp:" GridPane.columnIndex="0" GridPane.rowIndex="1" />
        <Label fx:id="labelmmmmppppp" prefHeight="57.0" prefWidth="875.0" styleClass="status" stylesheets="@styles.css" text="&lt;mmmm ppppp&gt;" GridPane.columnIndex="1" GridPane.rowIndex="1" />
        <!-- -->            

    </children>
    <rowConstraints>
        <RowConstraints />
        <RowConstraints />
    </rowConstraints>
    <padding>
        <Insets top="22.0" />
    </padding>
</GridPane>

<HBox alignment="TOP_CENTER">
    <Canvas fx:id="canvasKC" height="120.0" width="1070.0">
    <HBox.margin>
       <Insets bottom="22.0" />
    </HBox.margin></Canvas>
    <VBox.margin>
        <Insets top="22.0" />
    </VBox.margin>
</HBox>

pnahay commented 2 years ago

I tried copying and pasting the contents of the file into the message edit view, but it seems like it chopped off the code.

Anyway, I’m tired of this. You’ve got a bug in SB where in some situation CTRL+P won’t work. Forward this info to whomever coded the accelerators in SB.

Paul

P.S. Here’s the fxml code:

<?xml version="1.0" encoding="UTF-8"?>

<?import javafx.geometry.Insets?>

<?import javafx.scene.canvas.Canvas?>

<?import javafx.scene.control.Label?>

<?import javafx.scene.control.Menu?>

<?import javafx.scene.control.MenuBar?>

<?import javafx.scene.control.MenuItem?>

<?import javafx.scene.control.SeparatorMenuItem?>

<?import javafx.scene.input.KeyCodeCombination?>

<?import javafx.scene.layout.ColumnConstraints?>

<?import javafx.scene.layout.FlowPane?>

<?import javafx.scene.layout.GridPane?>

<?import javafx.scene.layout.HBox?>

<?import javafx.scene.layout.RowConstraints?>

<?import javafx.scene.layout.VBox?>

                                                            <VBox alignment="TOP_CENTER" prefWidth="190.0" styleClass="bbdvbox" ***@***.***">

                                                                            <children>

                                                                                            <Label alignment="TOP_CENTER" styleClass="bbdlabel" ***@***.***" text="bbbb" textAlignment="CENTER" />

                                                                                            <Label fx:id="labelbbbb" alignment="CENTER" maxWidth="1.7976931348623157E308" prefWidth="180.0" styleClass="bbdfield" ***@***.***" text="1" textAlignment="CENTER" />

                                                                            </children>

                                                            </VBox>

                                                            <VBox alignment="TOP_CENTER" prefWidth="190.0" styleClass="bbdvbox" ***@***.***">

                                                                            <children>

                                                                                            <Label alignment="TOP_CENTER" styleClass="bbdlabel" ***@***.***" text="dddd" textAlignment="CENTER" />

                                                                                            <Label fx:id="labelDiv" alignment="CENTER" maxWidth="1.7976931348623157E308" prefWidth="180.0" styleClass="bbdfield" ***@***.***" text="1" textAlignment="CENTER" />

                                                                            </children>

                                                            </VBox>

                                                            <VBox alignment="TOP_CENTER" prefWidth="190.0" styleClass="bbdvbox" ***@***.***">

                                                                            <children>

                                                                                            <Label alignment="TOP_CENTER" styleClass="bbdlabel" ***@***.***" text="ttttt" textAlignment="CENTER" />

                                                                                            <Label fx:id="labelttttt" alignment="CENTER" maxWidth="1.7976931348623157E308" prefWidth="180.0" styleClass="bbdfield" ***@***.***" text="1" textAlignment="CENTER" />

                                                                            </children>

                                                            </VBox>

                                            </children>

                            </HBox>

                            <GridPane alignment="CENTER" hgap="11.0" vgap="20.0" VBox.vgrow="NEVER">

                                            <columnConstraints>

                                                            <ColumnConstraints halignment="RIGHT" maxWidth="541.0" minWidth="10.0" prefWidth="211.0" />

                                                            <ColumnConstraints halignment="LEFT" maxWidth="867.0" minWidth="10.0" prefWidth="867.0" />

                                            </columnConstraints>

                                            <children>

                                                            <Label styleClass="bbdlabel" ***@***.***" text="ppppp ccccc:" GridPane.columnIndex="0" GridPane.rowIndex="0" />

                                                            <Label fx:id="labelpppppccccc" contentDisplay="CENTER" prefHeight="57.0" prefWidth="875.0" styleClass="status" ***@***.***" text="&lt;ppppp ccccc&gt;" GridPane.columnIndex="1" GridPane.rowIndex="0" />

                                                            <!-- -->                        

                                                            <Label styleClass="bbdlabel" ***@***.***" text="mmmm ppppp:" GridPane.columnIndex="0" GridPane.rowIndex="1" />

                                                            <Label fx:id="labelmmmmppppp" prefHeight="57.0" prefWidth="875.0" styleClass="status" ***@***.***" text="&lt;mmmm ppppp&gt;" GridPane.columnIndex="1" GridPane.rowIndex="1" />

                                                            <!-- -->            

                                            </children>

                                            <rowConstraints>

                                                            <RowConstraints />

                                                            <RowConstraints />

                                            </rowConstraints>

                                            <padding>

                                                            <Insets top="22.0" />

                                            </padding>

                            </GridPane>

                            <HBox alignment="TOP_CENTER">

                                            <Canvas fx:id="canvasKC" height="120.0" width="1070.0">

        <HBox.margin>

           <Insets bottom="22.0" />

        </HBox.margin></Canvas>

                                            <VBox.margin>

                                                            <Insets top="22.0" />

                                            </VBox.margin>

                            </HBox>

            </children>

Oliver-Loeffler commented 2 years ago

Thanks for your efforts. Well, did not know that there is a file type limitation on Github.

Renaming files from FXML to TXT would have helped, also adding both files to a ZIP and attaching the ZIP would have worked.

I'll try with the snippets you provided.

pnahay commented 2 years ago

Github won’t let me in. Here’s the code of File2, for which Ctrl+P doesn’t work in SB:

<?xml version="1.0" encoding="UTF-8"?>

<?import javafx.geometry.Insets?>

<?import javafx.scene.canvas.Canvas?>

<?import javafx.scene.control.Label?>

<?import javafx.scene.control.Menu?>

<?import javafx.scene.control.MenuBar?>

<?import javafx.scene.control.MenuItem?>

<?import javafx.scene.control.SeparatorMenuItem?>

<?import javafx.scene.input.KeyCodeCombination?>

<?import javafx.scene.layout.ColumnConstraints?>

<?import javafx.scene.layout.FlowPane?>

<?import javafx.scene.layout.GridPane?>

<?import javafx.scene.layout.HBox?>

<?import javafx.scene.layout.RowConstraints?>

<?import javafx.scene.layout.VBox?>

                                                            <VBox alignment="TOP_CENTER" prefWidth="190.0" styleClass="bbdvbox" ***@***.***">

                                                                            <children>

                                                                                            <Label alignment="TOP_CENTER" styleClass="bbdlabel" ***@***.***" text="bbbb" textAlignment="CENTER" />

                                                                                            <Label fx:id="labelbbbb" alignment="CENTER" maxWidth="1.7976931348623157E308" prefWidth="180.0" styleClass="bbdfield" ***@***.***" text="1" textAlignment="CENTER" />

                                                                            </children>

                                                            </VBox>

                                                            <VBox alignment="TOP_CENTER" prefWidth="190.0" styleClass="bbdvbox" ***@***.***">

                                                                            <children>

                                                                                            <Label alignment="TOP_CENTER" styleClass="bbdlabel" ***@***.***" text="dddd" textAlignment="CENTER" />

                                                                                            <Label fx:id="labelDiv" alignment="CENTER" maxWidth="1.7976931348623157E308" prefWidth="180.0" styleClass="bbdfield" ***@***.***" text="1" textAlignment="CENTER" />

                                                                            </children>

                                                            </VBox>

                                                            <VBox alignment="TOP_CENTER" prefWidth="190.0" styleClass="bbdvbox" ***@***.***">

                                                                            <children>

                                                                                            <Label alignment="TOP_CENTER" styleClass="bbdlabel" ***@***.***" text="ttttt" textAlignment="CENTER" />

                                                                                            <Label fx:id="labelttttt" alignment="CENTER" maxWidth="1.7976931348623157E308" prefWidth="180.0" styleClass="bbdfield" ***@***.***" text="1" textAlignment="CENTER" />

                                                                            </children>

                                                            </VBox>

                                            </children>

                            </HBox>

                            <GridPane alignment="CENTER" hgap="11.0" vgap="20.0" VBox.vgrow="NEVER">

                                            <columnConstraints>

                                                            <ColumnConstraints halignment="RIGHT" maxWidth="541.0" minWidth="10.0" prefWidth="211.0" />

                                                            <ColumnConstraints halignment="LEFT" maxWidth="867.0" minWidth="10.0" prefWidth="867.0" />

                                            </columnConstraints>

                                            <children>

                                                            <Label styleClass="bbdlabel" ***@***.***" text="ppppp ccccc:" GridPane.columnIndex="0" GridPane.rowIndex="0" />

                                                            <Label fx:id="labelpppppccccc" contentDisplay="CENTER" prefHeight="57.0" prefWidth="875.0" styleClass="status" ***@***.***" text="&lt;ppppp ccccc&gt;" GridPane.columnIndex="1" GridPane.rowIndex="0" />

                                                            <!-- -->                        

                                                            <Label styleClass="bbdlabel" ***@***.***" text="mmmm ppppp:" GridPane.columnIndex="0" GridPane.rowIndex="1" />

                                                            <Label fx:id="labelmmmmppppp" prefHeight="57.0" prefWidth="875.0" styleClass="status" ***@***.***" text="&lt;mmmm ppppp&gt;" GridPane.columnIndex="1" GridPane.rowIndex="1" />

                                                            <!-- -->            

                                            </children>

                                            <rowConstraints>

                                                            <RowConstraints />

                                                            <RowConstraints />

                                            </rowConstraints>

                                            <padding>

                                                            <Insets top="22.0" />

                                            </padding>

                            </GridPane>

                            <HBox alignment="TOP_CENTER">

                                            <Canvas fx:id="canvasKC" height="120.0" width="1070.0">

        <HBox.margin>

           <Insets bottom="22.0" />

        </HBox.margin></Canvas>

                                            <VBox.margin>

                                                            <Insets top="22.0" />

                                            </VBox.margin>

                            </HBox>

            </children>

Oliver-Loeffler commented 1 year ago

Very cool - I am able to reproduce the error. No clue why this happens yet but I'll figure out, Here is the FXML:

<?xml version="1.0" encoding="UTF-8"?>
<?import javafx.geometry.Insets?>
<?import javafx.scene.canvas.Canvas?>
<?import javafx.scene.control.Label?>
<?import javafx.scene.control.Menu?>
<?import javafx.scene.control.MenuBar?>
<?import javafx.scene.control.MenuItem?>
<?import javafx.scene.control.SeparatorMenuItem?>
<?import javafx.scene.input.KeyCodeCombination?>
<?import javafx.scene.layout.ColumnConstraints?>
<?import javafx.scene.layout.FlowPane?>
<?import javafx.scene.layout.GridPane?>
<?import javafx.scene.layout.HBox?>
<?import javafx.scene.layout.RowConstraints?>
<?import javafx.scene.layout.VBox?>
<VBox alignment="TOP_CENTER" xmlns="http://javafx.com/javafx/18"
  xmlns:fx="http://javafx.com/fxml/1"
  fx:controller="n.rrrrrrr.ControllerMain">
  <children>
    <MenuBar VBox.vgrow="NEVER">
      <menus>
        <Menu text="_File">
          <items>
            <MenuItem onAction="#onOpenFile" text="_Open File…">
              <accelerator>
                <KeyCodeCombination alt="UP" code="O" control="DOWN" meta="UP" shift="UP" shortcut="UP" />
              </accelerator>
            </MenuItem>
            <MenuItem onAction="#onCloseFile" text="_Close..." />
            <SeparatorMenuItem mnemonicParsing="false" />
            <MenuItem onAction="#onFileProperties" text="File _Properties...">
              <accelerator>
                <KeyCodeCombination alt="UP" code="P" control="DOWN" meta="UP" shift="UP" shortcut="UP" />
              </accelerator>
            </MenuItem>
            <MenuItem onAction="#onQuit" text="_Quit...">
              <accelerator>
                <KeyCodeCombination alt="UP" code="Q" control="DOWN" meta="UP" shift="UP" shortcut="UP" />
              </accelerator>
            </MenuItem>
          </items>
        </Menu>
        <Menu text="_per">
          <items>
            <MenuItem mnemonicParsing="false" onAction="#onGoToFirstxxxxxccccc" text="First xxxxx ccccc">
              <accelerator>
                <KeyCodeCombination alt="ANY" code="HOME" control="UP" meta="UP" shift="UP" shortcut="UP" />
              </accelerator>
            </MenuItem>
            <MenuItem mnemonicParsing="false" onAction="#onGoToLastxxxxxccccc" text="Last xxxxx ccccc">
              <accelerator>
                <KeyCodeCombination alt="ANY" code="END" control="UP" meta="UP" shift="UP" shortcut="UP" />
              </accelerator>
            </MenuItem>
            <MenuItem mnemonicParsing="false" onAction="#onGoToPreviousxxxxxccccc" text="Previous xxxxx ccccc">
              <accelerator>
                <KeyCodeCombination alt="ANY" code="LEFT" control="UP" meta="UP" shift="UP" shortcut="UP" />
              </accelerator>
            </MenuItem>
            <MenuItem mnemonicParsing="false" onAction="#onGoToNextxxxxxccccc" text="Next xxxxx ccccc">
              <accelerator>
                <KeyCodeCombination alt="ANY" code="RIGHT" control="UP" meta="UP" shift="UP" shortcut="UP" />
              </accelerator>
            </MenuItem>
            <MenuItem mnemonicParsing="false" onAction="#onGoToPreviousxxxxxcccccBar" text="Previous xxxxx ccccc bbb">
              <accelerator>
                <KeyCodeCombination alt="ANY" code="PAGE_UP" control="UP" meta="UP" shift="UP" shortcut="UP" />
              </accelerator>
            </MenuItem>
            <MenuItem mnemonicParsing="false" onAction="#onGoToNextxxxxxcccccBar" text="Next xxxxx ccccc bbb">
              <accelerator>
                <KeyCodeCombination alt="ANY" code="PAGE_DOWN" control="UP" meta="UP" shift="UP" shortcut="UP" />
              </accelerator>
            </MenuItem>
            <MenuItem onAction="#onAllnnnnnOff" text="All nnnnn _Off">
              <accelerator>
                <KeyCodeCombination alt="UP" code="ESCAPE" control="ANY" meta="UP" shift="UP" shortcut="UP" />
              </accelerator>
            </MenuItem>
            <MenuItem mnemonicParsing="false" onAction="#onPanic" text="Panic">
              <accelerator>
                <KeyCodeCombination alt="UP" code="SPACE" control="ANY" meta="UP" shift="UP" shortcut="UP" />
              </accelerator>
            </MenuItem>
          </items>
        </Menu>
        <Menu text="_Setup">
          <items>
            <MenuItem onAction="#onDlgmmmmppppp" text="_mmmm ppppp...">
              <accelerator>
                <KeyCodeCombination alt="UP" code="M" control="DOWN" meta="UP" shift="UP" shortcut="UP" />
              </accelerator>
            </MenuItem>
          </items>
        </Menu>
        <Menu text="_Help">
          <items>
            <MenuItem onAction="#onAboutrrrrrrr" text="_About rrrrrrr..." />
            <MenuItem mnemonicParsing="false" onAction="#onOpenHomePage" text="Open http://b.s" />
          </items>
        </Menu>
      </menus>
    </MenuBar>
    <FlowPane alignment="CENTER">
      <children>
        <Label fx:id="labelssssTitle" alignment="CENTER" styleClass="ssss-title" text="&lt;My Very, Very, Very, Very  Long ssss Title&gt;" textAlignment="CENTER" />
      </children>
      <VBox.margin>
        <Insets top="22.0" />
      </VBox.margin>
    </FlowPane>
  </children>
</VBox>
pnahay commented 1 year ago

GREAT, all the hassle conveying this to y’all was then worth it.

Hope you can fix it.

BTW, it’s a very confusing program to use (SceneBuilder).

Paul

From: Oliver Löffler @.*** Sent: Thursday, October 20, 2022 3:18 PM To: gluonhq/scenebuilder Cc: pnahay; Mention Subject: Re: [gluonhq/scenebuilder] Version 18.0.0 bug. (Issue #553)

Very cool - I am able to reproduce the error. No clue why this happens yet but I'll figure out, Here is the FXML:

<?xml version="1.0" encoding="UTF-8"?>

<?import javafx.geometry.Insets?>

<?import javafx.scene.canvas.Canvas?>

<?import javafx.scene.control.Label?>

<?import javafx.scene.control.Menu?>

<?import javafx.scene.control.MenuBar?>

<?import javafx.scene.control.MenuItem?>

<?import javafx.scene.control.SeparatorMenuItem?>

<?import javafx.scene.input.KeyCodeCombination?>

<?import javafx.scene.layout.ColumnConstraints?>

<?import javafx.scene.layout.FlowPane?>

<?import javafx.scene.layout.GridPane?>

<?import javafx.scene.layout.HBox?>

<?import javafx.scene.layout.RowConstraints?>

<?import javafx.scene.layout.VBox?>

<VBox alignment="TOP_CENTER" xmlns="http://javafx.com/javafx/18"

xmlns:fx="http://javafx.com/fxml/1"

fx:controller="n.rrrrrrr.ControllerMain">

— Reply to this email directly, view it on GitHub https://github.com/gluonhq/scenebuilder/issues/553#issuecomment-1286023265 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AADX6EY4NOPFWEPDP6HTH7TWEGLFXANCNFSM5STW27VQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AADX6E3WBJZILW4G3MXAWZDWEGLFXA5CNFSM5STW27V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJSTSQYI.gif Message ID: @.***>

Oliver-Loeffler commented 1 year ago

The cause of the failing preview is, that Scene Builders preview accelerator CTRL+P is kind of shadowed by another accelerator definition inside the FXML. All accelerators inside the FXML are basically working. Not sure how to handle this.

Following FXML code makes the preview accelerator fail:

<MenuItem onAction="#onFileProperties" text="File _Properties...">
    <accelerator>
        <KeyCodeCombination alt="UP" code="P" control="DOWN" meta="UP" shift="UP" shortcut="UP" />
    </accelerator>
</MenuItem>

The following setup will work fine:

<MenuItem onAction="#onFileProperties" text="File _Properties...">
    <accelerator>
        <KeyCodeCombination alt="UP" code="X" control="DOWN" meta="UP" shift="UP" shortcut="UP" />
    </accelerator>
</MenuItem>

Its as simple as either removing the accelerator at all or mapping it on another KeyCode. Nevertheless, this is an unaccaptable application behavior. I think it will be okay to capture the key events in a running preview but not in the editing view. The solution here might be either to capture the preview accelerator separately or even prevent accelerators in document window from being captured. As a first step, I'll issue a PR to capture the preview accelerator separately.

pnahay commented 1 year ago

Yes, clearly shouldn’t work this way. Using CTRL+P to open the preview window shouldn’t, logically, have anything to do with (or any conflict with) the user’s FXML that defines using CTRL+P in the user’s JavaFX application.

Paul

From: Oliver Löffler @.*** Sent: Thursday, October 20, 2022 3:32 PM To: gluonhq/scenebuilder Cc: pnahay; Mention Subject: Re: [gluonhq/scenebuilder] Version 18.0.0 bug. (Issue #553)

The cause of the failing preview is, that Scene Builders preview accelerator CTRL+P is kind of shadowed by another accelerator definition inside the FXML. All accelerators inside the FXML are basically working. Not sure how to handle this.

Following FXML code makes the preview accelerator fail:

The following setup will work fine:

Its as simple as either removing the accelerator at all or mapping it on another KeyCode. Nevertheless, this is an unaccaptable application behavior.

— Reply to this email directly, view it on GitHub https://github.com/gluonhq/scenebuilder/issues/553#issuecomment-1286038978 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AADX6EYVLGIYUDDRPGJF3IDWEGMZTANCNFSM5STW27VQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AADX6E3FHAZRKTJO7ZWP6NDWEGMZTA5CNFSM5STW27V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJSTWLQQ.gif Message ID: @.***>

Oliver-Loeffler commented 1 year ago

Please test PR #593 if this would work for you. As of now I definitely read more into the Scene Builder and JavaFX code to find a better solution for this issue.

Oliver-Loeffler commented 1 year ago

@pnahay Which points are confusing? Thats something which potentially could be improved.

pnahay commented 1 year ago

Yay, the system works!

From: Oliver Löffler @.*** Sent: Thursday, October 20, 2022 4:42 PM To: gluonhq/scenebuilder Cc: pnahay; Mention Subject: Re: [gluonhq/scenebuilder] Version 18.0.0 bug. (Issue #553)

Please test PR #593 https://github.com/gluonhq/scenebuilder/pull/593 if this would work for you. As of now I definitely read more into the Scene Builder and JavaFX code to find a better solution for this issue.

— Reply to this email directly, view it on GitHub https://github.com/gluonhq/scenebuilder/issues/553#issuecomment-1286123857 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AADX6E4JXCJD5EWYQKFF6JTWEGVANANCNFSM5STW27VQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AADX6EYWEVW3PQ4GBILU2JLWEGVANA5CNFSM5STW27V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJSULCUI.gif Message ID: @.***>

pnahay commented 1 year ago

I would really have to spend time I don’t have, writing a short article about this.

There’s actually another issue in the left “sliding section” view that I need to document for you, but don’t have time now.

From: Oliver Löffler @.*** Sent: Thursday, October 20, 2022 4:48 PM To: gluonhq/scenebuilder Cc: pnahay; Mention Subject: Re: [gluonhq/scenebuilder] Version 18.0.0 bug. (Issue #553)

@pnahay https://github.com/pnahay Which points are confusing? Thats something which potentially could be improved.

— Reply to this email directly, view it on GitHub https://github.com/gluonhq/scenebuilder/issues/553#issuecomment-1286131193 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AADX6E3WOQQVIEXYIZTW2LLWEGVXZANCNFSM5STW27VQ . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AADX6E7ZFQYBGA2FL6FBM7DWEGVXZA5CNFSM5STW27V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOJSUM36I.gif Message ID: @.***>