Open batashi opened 2 years ago
Hello @batashi,
thanks for issuing this. I will look into this and will see to solve this issue. I'll try to reproduce in a VM.
As a workaround, you can instruct Maven, to skip tests. For this run:
mvn clean package -DskipTests=true
Alternatively you can skip those particular failing tests, so you can at least build and package:
mvn package -Dtest="*,!SkeletonBufferJavaTest,!SkeletonBufferJavaTest"
When you execute the comman git config --list
, git will show its configuration parameters.
Could you please share the value your effective core.autocrlf=
configuration property?
Regards!
@AlmasB Could you please assign this one to me?
Thanks forthe prompt replay @Oliver-Loeffler
Below is the output of git config --list
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true
remote.origin.url=https://github.com/gluonhq/scenebuilder.git
remote.origin.fetch=+refs/heads/:refs/remotes/origin/
branch.master.remote=origin
branch.master.merge=refs/heads/master
branch.sb17.remote=origin
branch.sb17.merge=refs/heads/sb17
Regards
Scene Builder is now available on Flathub. @batashi did the original work, I followed up afterwards.
If any of the Scene Builder
maintainers would like to be part of maintains the flatpak, please reach out!
Flathub manifest: https://github.com/flathub/com.gluonhq.SceneBuilder
Flathub link: https://flathub.org/apps/details/com.gluonhq.SceneBuilder
Flathub badge: <a href='https://flathub.org/apps/details/com.gluonhq.SceneBuilder'><img width='240' alt='Download on Flathub' src='https://flathub.org/assets/badges/flathub-badge-en.png'/></a>
Flathub badge sample:
How did you solve the issue? Do you exclude the tests?
Hi @batashi I was able to reproduce this in one fresh Fedore 36 VM, in another Fedore 36 VM I failed to reproduce..
The error seems to be related to the multi-project nature of Scene Builder and I was able to resolve it with running mvn install
.
After that, the error disappeared. I have to admit, that I need to dig deeper into Maven life cycle. Nevertheless, mvn install
upfront helped to avoid the problem. Seems to be a similar problem like when one attempts to run Scene Builder from command line using mvn javafx:run -f app
. This also requires an invocation of mvn install
upfront.
@batashi , @AlmasB
Would it be acceptable for you, if I would update the README.md
for that?
I would prefer (just for now) not to touch the POM.xml
at this moment but rather read more into Maven Life Cycle in order to really understand this behavior.
This seems to be really unrelated to my very first impression, which was something with line endings in Git- But to exclude this, please try to clone Scene Builder into a location. The line-endings can be a topic for old repositories but should not be an issue for new clones.
The exception you've pointed out in the original issue is by intent - its a test for an edge case, so the exception there was expected. But the other failing tests weren't.
Thanks! Oliver
Hi Team, Thanks for your great tool.
I am trying to build this locally on my machine to setup a flatpak version of scenebuilder. I'm facing the below error when I run first maven command
mvn clean package
Aug 06, 2022 3:26:35 PM com.oracle.javafx.scenebuilder.kit.skeleton.SkeletonFileWriter logErrorAndNotifyUser SEVERE: Could not write controller skeleton to file: /notExisting/share/test.java . java.nio.file.NoSuchFileException: /notExisting/share/test.java
The complete output below:
Expected Behavior
run without error
Current Behavior
not passed mvn clean
Steps to Reproduce
Your Environment
Fedora 36 OpenJdk 17.0.4