Let Android OS handle volume events

gluonhq / substrate

Create native Java(FX) apps for desktop, mobile and embedded

GNU General Public License v2.0

372 stars 51 forks source link

Let Android OS handle volume events #1209

Closed jperedadnr closed 1 year ago

jperedadnr commented 1 year ago

Issue

Fixes #1208

Progress

[ ] Change must not contain extraneous whitespace
[ ] License header year is updated, if required
[ ] Verify the contributor has signed Gluon Individual Contributor License Agreement (CLA)

salmonb commented 1 year ago

I tested this PR along with my PR regarding the AndroidAudioService, and my tests confirm that this PR is fixing the issue with the volume buttons: now they are simply handled by Android, without the need to rewrite the code for the volume management in the service (calling activity.setVolumeControlStream() is enough to make the volume buttons work) 👍

jperedadnr commented 1 year ago

Great, thanks for testing!