search

gluons / font-awesome-openui5

Font Awesome icons for OpenUI5.
https://git.io/font-awesome-openui5
MIT License
0 stars 2 forks source link

icons will not render without font-weight: 900 #4

Open TonisPiip opened 6 years ago

TonisPiip commented 6 years ago

Some icons will not render unless the icon has the CSS property font-weight: 900; Inside ui5 library.css it defines the following rule:

.sapUiIcon::before { content: attr(data-sap-ui-icon-content); speak: none; font-weight: normal; -webkit-font-smoothing: antialiased; }

If I manually edit the rule to 900 it renders correctly.

Not sure how this is best fixed... Perhaps a new rule of font-weight: 900; !important somewhere.

gluons commented 6 years ago

Have you followed this guide in Get Started page?

default

TonisPiip commented 6 years ago

Must have missed that note.However I'm building the page using the Xml layout.That and the fact that in generating the xml from other data I would rather not have to add all these extra classes.One solution which worked was to overwrite that rule with font-weight : inherit.!important. Then to edit the font awesome css, so that the solid fonts have a separate font family name.Then I edited your code so when adding the icons it uses the new font family name.This seems to work, it allows the font weight defined in the all.css to be applied to just the solid fonts.Ive made a fork, and built a working dist but have yet to Commit my chances.-------- Original Message --------Subject: Re: [gluons/font-awesome-openui5] icons will not render without font-weight: 900 (#4)From: Saran Tanpituckpong To: gluons/font-awesome-openui5 CC: Tonis Piip ,Author Have you followed this guide in Get Started page?

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.