search

gluons / vue-github-buttons

:octocat: GitHub buttons component for Vue.
https://git.io/vue-github-buttons
Apache License 2.0
37 stars 10 forks source link

Register components using pascal casing #23

Closed idelsink closed 4 years ago

idelsink commented 4 years ago

Register components using pascal casing so that both PascalCase and kebab-case can be used for the components.

When defining a component with PascalCase, you can use either case when referencing its custom element. That means both and are acceptable. Taken from: https://vuejs.org/v2/guide/components-registration.html#With-PascalCase

Example

Source: https://github.com/gluons/vue-github-buttons/blob/master/src/index.ts#L35

vue.component('GhBtnsStar', Star);
vue.component('GhBtnsFork', Fork);
vue.component('GhBtnsWatch', Watch);
vue.component('GhBtnsFollow', Follow);
issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.86. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

idelsink commented 4 years ago

See pr: https://github.com/gluons/vue-github-buttons/pull/24

gluons commented 4 years ago

OK. Thank you for letting me know about it and your PR.
Good point.