glushchenko / fsnotes

Notes manager for macOS/iOS
https://fsnot.es
MIT License
6.47k stars 474 forks source link

Open note disappears when you press escape, even when sidebars are hidden #1430

Closed nth-chile closed 1 year ago

nth-chile commented 1 year ago

Description

Sometimes when I'm editing a note, I accidentally press escape and the note disappears from the editor pane. This is especially frustrating when the sidebars are hidden. I know that pressing escape moves the cursor to the search field, but I don't see why it should clear the editor pane. It's also a little chaotic that typing in the search field selects notes and makes them show up in the editor. As I type more letters into the search field, the notes in the editor are flashing by. Usually at this point I just remember the name of the note I was working on and type it in to get it to show up again.

Sometimes I want to use the search field but I don't want my current note to disappear until I click on the next note that I'm searching for.

To Reproduce

  1. Select a note
  2. Hide sidebars
  3. Press escape
  4. Screen goes blank. If you press any letter key, a different note opens

Expected behavior

FSNotes version

6

macOS/iOS version

13

Additional context

No response

tewe commented 1 year ago

Typing in the search bar should definitely open notes, that's the whole point of the thing.

You can use ⌘ L instead of ESC to jump to the search bar without clearing the editor.

nth-chile commented 1 year ago

Why can't it work like Xcode, VSCode, Sublime Text, Notion. Bear, Apple Notes, etc. by not flashing notes across the editor?

tewe commented 1 year ago

Apple Notes works exactly the same, except it waits some milliseconds for you to finish typing before it updates the results list. So it is slower to use. That's why somebody created Notational Velocity (meaning fast) which FSNotes is inspired by.

nth-chile commented 1 year ago

Alright, true. But I would say two changes could be made to make it more intentional, since I seem to do it accidentally and lose my note:

I might be able to submit a couple of PRs for those two things actually

tewe commented 1 year ago

As I said, ⌘ L fulfils both of your requirements, though there seems to be a bug where it sometimes shows a pop-up menu and you have to hit it again to unhide the notes list.

nth-chile commented 1 year ago

True.

🤔 I'll have to pay attention next time to see why I press escape and expect something else. Maybe to deselect text?

Is it strange that it's even possible to use the sidebars while they are hidden?