search

glushchenko / fsnotes

Notes manager for macOS/iOS
https://fsnot.es
MIT License
6.47k stars 474 forks source link

Can't save revision in git after upgrading to 6.3.0 #1538

Closed michaelrrrrrr closed 1 year ago

michaelrrrrrr commented 1 year ago

Description

After upgrading to 6.3.0, any edits will not be saved by Ctrl+S, while an error message is prompted: The operation couldn’t be completed. (FSNotes.GitError error 7.)

I have never changed the default settings of git. Everything in Preference>Git remained intact.

To Reproduce

  1. Do any edits
  2. Click Ctrl+S
  3. An error prompt will be shown immediately

Expected behavior

No response

FSNotes version

6.3.0

macOS/iOS version

macOS Monterey 12.6.3

Additional context

No response

glushchenko commented 1 year ago

Looks like a hotfix is required, thank you.

michaelrrrrrr commented 1 year ago

Looks like a hotfix is required, thank you.

No worries.

glushchenko commented 1 year ago

Please try https://github.com/glushchenko/fsnotes/releases/download/6.3.2/FSNotes_6.3.2.zip

And post here a new error message.

michaelrrrrrr commented 1 year ago

Please try https://github.com/glushchenko/fsnotes/releases/download/6.3.2/FSNotes_6.3.2.zip

And post here a new error message.

I already updated the app to 6.3.2 via App Store.

Now the prompt message is changed to Unable to save index -14 the index is locked; this might be due to a concurrent or crashed process.

michaelrrrrrr commented 1 year ago

Did nothing after receiving the last prompt message, but a new message came up when I clicked 'Ctrl+S' as usual.

Unable to open repository, url: file:///Users/michaelren/Library/Containers/co.fluder.FSNotes/Data/Library/Application%20Support/Repositories/b1ae%20-%20Changelogs.git -3 failed to resolve path '/Users/michaelren/Library/Containers/co.fluder.FSNotes/Data/Library/Application Support/Repositories/b1ae - Changelogs.git': No such file or directory

glushchenko commented 1 year ago

This means there is no repository in the specified path, you can create a new one or put the old one.

michaelrrrrrr commented 1 year ago

This means there is no repository in the specified path, you can create a new one or put the old one.

I found some auto-generated git repos under that path, and they are FSNotes.git, Trash.git, Notes.git and two Archive.git repos.

The "Changelogs" of the missing Changelogs.git in the prompt message refers to a folder, which I created in the FSNote app. I've seen none of the folders I created in the app had a corresponding git repo under the path. And I have no idea how to create a git repo refering to the folder.

Plus, I found there was always a similar error msg if I tried to save revision (Ctrl+S) in other folder of the app. I'm wondering if "save revision" is a proper way to save/sync my edits to the iCloud/some server/local store path?

I am sure my edits would be synced across all my devices, even if I couldn't "save revision". I guess this is due to the iCloud sync.

pessinafederico commented 1 year ago

Hello Michael, let me know if you have found a solution, I have the same issue

glushchenko commented 1 year ago

Guys, repositories used to be generated automatically, now you have to create them manually in the project settings, or in the Preferences.

image

Init/commit button.

If path to repository changed, git will not work and must be reinited. And it has nothing to do with synchronisation via iCloud Drive.

PeterGumball commented 1 year ago

Have the same problem, see (https://github.com/glushchenko/fsnotes/issues/1544)

Nothing works for me, even when I remove the Repositories folder and init a new for project/global. I always get the same error.

I'm not creating a repository for now and use FSNotes without git now.

glushchenko commented 1 year ago

@PeterGumball @pessinafederico @michaelrrrrrr please try this build https://github.com/glushchenko/fsnotes/releases/download/6.3.3/FSNotes_6.3.3.zip

PeterGumball commented 1 year ago

@glushchenko

Great, that works for me. Now I only get the message that there are no new files if I don't change anything and press ⌘ S, but I can live with that. It is in my developer head that I always have to press ⌘ S.

Thanks for your quick help.

glushchenko commented 1 year ago

@PeterGumball agree, this is a temporary solution, I will remove this nag in the next releases, now there is no time. Thank you!

michaelrrrrrr commented 1 year ago

@PeterGumball @pessinafederico @michaelrrrrrr please try this build https://github.com/glushchenko/fsnotes/releases/download/6.3.3/FSNotes_6.3.3.zip

image

ouch I drag the new app into the Application folder, replace the old one with new app, and all my notes are gone...

glushchenko commented 1 year ago

@michaelrrrrrr github version dont use iCloud Drive by default, you should select storage in settings manually.

michaelrrrrrr commented 1 year ago

@glushchenko All good now. I remove the original git settings in the Preferences and initialize a new one. Git works fine then. Thanks for the help.

@pessinafederico Try the new app published by @glushchenko. Everything works fine now.

pessinafederico commented 1 year ago

Thank you! Have a good one Sent from my iPhoneOn 10 Jun 2023, at 13:51, glushchenko @.***> wrote: @michaelrrrrrr github version dont use icloud by default, you should select storage in settings manually.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>