search

glushchenko / fsnotes

Notes manager for macOS/iOS
https://fsnot.es
MIT License
6.22k stars 458 forks source link

Bold does not get bold (same for italic) #1558

Closed igr closed 1 year ago

igr commented 1 year ago

Description

The following example:

**Development approach**:

does not get bold:

CleanShot 2023-06-21 at 08 12 35

but this works (space added before the :):

**Development approach** :

CleanShot 2023-06-21 at 08 15 02

To Reproduce

Type **foo**: hello

Expected behavior

UI should make text bold (or italic)

FSNotes version

Version 6.3.3 (578)

macOS/iOS version

latest

Additional context

No response

gingerbeardman commented 1 year ago

Markdown is handled by a library, Markdown.swift which uses libcmark_gfm which is the stringent CommonMark spec.

You can try it here: https://spec.commonmark.org/dingus/

And if the problem still exists it will be because of CommonMark.

igr commented 1 year ago

@gingerbeardman It works on the dingus example:

CleanShot 2023-06-21 at 23 50 16

gingerbeardman commented 1 year ago

Great! Then over to @glushchenko when he returns

Bug is likely in this function: https://github.com/glushchenko/fsnotes/blob/d5e37c2fb2f1d840fe56c5e85666eb84db6178c2/FSNotes/Helpers/NotesTextProcessor.swift#L512

glushchenko commented 1 year ago

@gingerbeardman exactly :) @igr thank you for report, fixed.

glushchenko commented 1 year ago

https://github.com/glushchenko/fsnotes/releases/download/6.4.0/FSNotes_6.4.0.zip