glushchenko / fsnotes

Notes manager for macOS/iOS
https://fsnot.es
MIT License
6.37k stars 468 forks source link

Grammar Issue In error message + localization error #1654

Closed theomiddleton closed 9 months ago

theomiddleton commented 9 months ago

Description

When you get the popup of moving your old database to icloud, it has some grammar issues. It reads "We are detect that you are install FSNotes from Mac App Store with default storage in iCloud Drive, do you want to move old database in iCloud Drive?" This is on line 11304 of Localizable.xcstrings

image Better wording/ proper English would something like: "We have detected that you have installed FSNotes from Mac App Store with default storage in iCloud Drive, do you want to move old database into iCloud Drive?" Also on the Dutch translation for this error it is in English, not Dutch. Line 11357.

To Reproduce

  1. Update FSNotes with old database on drive, but have the default storage settings to be in icloud.
  2. Open
  3. See error

Expected behavior

No response

FSNotes version

6.6.2 (605)

macOS/iOS version

13.6.1

Additional context

No response

glushchenko commented 9 months ago

https://github.com/glushchenko/fsnotes/releases/tag/6.6.3