Providing fix to the issue #154

gluster / build-jobs

Jenkins jobs for the Gluster project

https://build.gluster.org/

MIT License

0 stars 14 forks source link

Closed rakshithakamath94 closed 2 years ago

rakshithakamath94 commented 2 years ago

Hi @mscherer and @deepshikhaaa,

Please do review this PR.

mscherer commented 2 years ago

Seems good. I kinda feel this would be the right time to refactor the version in a variable or something, but this is not a big deal.

deepshikhaaa commented 2 years ago

Looks good to me. Merging it.

mscherer commented 2 years ago

So I didn't see the removal of -Werror (which is one more reason to refactor). I think we should keep it. If there is a warning, it should not pass.