search

gluster / gluster-ansible-features

Ansible role to enable a Gluster cluster with gluster-specific features like samba, ganesha etc.
GNU General Public License v3.0
10 stars 14 forks source link

ctdb: make enabling ctdb hook scripts configurable #43

Closed obnoxxx closed 4 years ago

obnoxxx commented 4 years ago

It is not always desirable to have the ctdb hook scripts start/stop the ctdb service and fiddle with the fstab for the lock volume. This patch introduces a variable gluster_features_ctdb_enable_hook_script defaulting to true which can be set to false to disable the enablement of the hook scripts.

Signed-off-by: Michael Adam obnox@samba.org

obnoxxx commented 4 years ago

Note: not tested yet.

obnoxxx commented 4 years ago

@spuiuk, @anoopcs9, would there be a way to test this in https://github.com/gluster/samba-integration?

anoopcs9 commented 4 years ago

@spuiuk, @anoopcs9, would there be a way to test this in https://github.com/gluster/samba-integration?

May be I can create a gluster-ansible-features build with this change under Fedora copr and enable it for testing purpose through a PR?

In samba-integration we just to have to add along the following lines:

- name: Mount and add CTDB lock volume mount to fstab
  mount:
    path: /gluster/lock/
    src: 'localhost:/ctdb'
    fstype: glusterfs
    opts: '_netdev,transport=tcp,xlator-option=*client*.ping-timeout=10'
    state: mounted

and with _gluster_features_ctdb_enable_hookscripts set to 'false'

anoopcs9 commented 4 years ago

@spuiuk, @anoopcs9, would there be a way to test this in https://github.com/gluster/samba-integration?

https://github.com/gluster/samba-integration/pull/83

anoopcs9 commented 4 years ago

@spuiuk, @anoopcs9, would there be a way to test this in https://github.com/gluster/samba-integration?

This is now tested successfully !!

obnoxxx commented 4 years ago

@anoopcs9 thanks, this is fantastic! :-)

I'm also excited to see that the CI infrastructure we added in the https://github.com/gluster/samba-integration repo made it reatively easy to test this.

@sac, @gobindadas - can we merge this one? It won't change the default behavior.

obnoxxx commented 4 years ago

@gobindadas , @sac - ping? :smiley:

sac commented 4 years ago

Looks good to me. @obnoxxx I'm sorry about the delay, I was little busy.

obnoxxx commented 4 years ago

@sac wrote:

Looks good to me. @obnoxxx I'm sorry about the delay, I was little busy.

No worries, it was not urgent. Thanks for merging!

anoopcs9 commented 4 years ago

Looks good to me. @obnoxxx I'm sorry about the delay, I was little busy.

@sac Can you please update gluster-ansible-features on Fedora copr so as to get this fix included.

sac commented 4 years ago

Looks good to me. @obnoxxx I'm sorry about the delay, I was little busy.

@sac Can you please update gluster-ansible-features on Fedora copr so as to get this fix included.

@anoopcs9 I no longer handle that account. @gobindadas or @pkesavap should be able to help you with that.