search

gluster / gluster-ansible-infra

Ansible role to enable and deploy the backend of a Gluster cluster.
GNU General Public License v3.0
28 stars 36 forks source link

put condition before regenerate of lvm filter #111

Closed pkesavap closed 3 years ago

pkesavap commented 3 years ago

Only execute regeneration of new lvm filter if vdsm-python is installed and gluster_infra_lvm is defined

possible fix for :https://github.com/gluster/gluster-ansible-infra/issues/110

pkesavap commented 3 years ago

requesting review : @gobindadas @satheesaran

rkothiya commented 3 years ago

Getting the following error : 

TASK [gluster.infra/roles/backend_setup : Check if vdsm-python package is installed or not] ***

[WARNING]: Consider using the yum, dnf or zypper module rather than running
'rpm'.  If you need to use command because yum, dnf or zypper is insufficient
you can add 'warn: false' to this command task or set 'command_warnings=False'
in ansible.cfg to get rid of this message.
fatal: [server1.example.com]: FAILED! => {"changed": true, "cmd": ["rpm", "-q", "vdsm-python"], "delta": "0:00:00.172158", "end": "2020-10-12 09:37:46.929268", "msg": "non-zero return code", "rc": 1, "start": "2020-10-12 09:37:46.757110", "stderr": "", "stderr_lines": [], "stdout": "package vdsm-python is not installed", "stdout_lines": ["package vdsm-python is not installed"]}
pkesavap commented 3 years ago

updated the file with ignore_errors: yes

its failing , when the package is not there, so as of now its safe to ignore_errors , , can you try again @rkothiya

gobindadas commented 3 years ago

Looks good to me, merging this.