gluster / gluster-ansible

A core library of gluster specific roles and modules for ansible/ansible tower.
GNU General Public License v3.0
189 stars 54 forks source link

RFE: Replace host for same fqdn #108

Closed gobindadas closed 4 years ago

gobindadas commented 4 years ago

RHBZ: 1832658

satheesaran commented 4 years ago

@gobindadas Please add clean and easily understandable comments in the node_replace_inventory.yml file.

pkesavap commented 4 years ago

also just wanted to know, wouldn't it be better to include two inventory in the same file, because node_replace_inventory.yml should be executed in the gluster_maintancence host, but the node_prep could does not have any such restriction, since the node_prep is there for replace host flow, wouldnt it be better to have a good single inventory file for replace host, rather than multiple?

satheesaran commented 4 years ago

@gobindadas While executing the replace_host playbook, I was seeing this warning "The loop variable 'item' is already in use." for every task execution, I have supplemented 'with_items' with loop_control and loop_variable and that solved the problem


pkesavap commented 4 years ago

Vars needs to be intended

Apologies, It is properly intended, issue was with my setup

gobindadas commented 4 years ago

Fixed all comments