search

gluster / gluster-block

A framework for gluster block storage
GNU General Public License v2.0
74 stars 32 forks source link

create: turn 'prealloc full' by default #191

Closed pkalever closed 5 years ago

pkalever commented 5 years ago

As of now prealloc is off by default. This patch change the default prealloc to full.

Fixes: #149 Signed-off-by: Prasanna Kumar Kalever prasanna.kalever@redhat.com

pkalever commented 5 years ago

@amarts @lxbsz please take a look. Thanks!

lxbsz commented 5 years ago

@amarts @lxbsz please take a look. Thanks!

@pkalever Since we are changing the cli exported to users/customers, how about add this with one version or minor version update ? Then it will be more easy for the hekti or other upper layer tool to adapt the new changes.

pkalever commented 5 years ago

@pkalever Since we are changing the cli exported to users/customers, how about add this with one version or minor version update ? Then it will be more easy for the hekti or other upper layer tool to adapt the new changes.

Heketi by default call cli 'prealloc full' options with gluster-block create. Hence I don't see any issues with it.

If needed we can allow users set their default choice with config file option too, let me know if that is what you want.

Thanks!

pkalever commented 5 years ago

LGTM

Please make sure to call this out in the release notes.

Sure, will add this. Thanks @amarts !

Reviewed By: Amar Tumballi amarts@redhat.com

pkalever commented 5 years ago

Updated tags, ready for merge. Thanks!