search

gluster / gluster-block

A framework for gluster block storage
GNU General Public License v2.0
74 stars 32 forks source link

gluster-block: fix block delete failure #217

Closed pkalever closed 5 years ago

pkalever commented 5 years ago

What does this PR achieve? Why do we need it?

Problem:

TEST : gluster-block delete hosting-volume/block-volume FAILED ON: 192.168.124.147 SUCCESSFUL ON: None RESULT: FAIL line 98 : NOT OK

Solution:

This is because, the below command was failing,

$ targetcli /backstores/user:glfs delete name=block-volume save=True Unexpected keyword parameter 'save'.

Since, gluster-block now use per storage object save feature of targetcli,

need, below commit from targetcli, to fix delete failures:


commit bca03ea400a691e4218113b6d10adb61ce0cd511 (refs/remotes/origin/save_del)
  Author: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
  Date:   Fri Jun 1 16:15:22 2018 +0530

      saveconfig: way for block-level save with delete comman

which is part of targetcli-2.1.fb49, hence turning the dependency check to latest released and packaged version.

Signed-off-by: Prasanna Kumar Kalever prasanna.kalever@redhat.com

pkalever commented 5 years ago

Thanks @lxbsz. Merging now.