lxbsz
commented
5 years ago The 2 issues will be:
Create 2 blocks with the same name "block0" and in different gluster volumes, "dht" and "dht1", there will be 2 Targets with only one StorageObject:
]# gluster-block create dht1/block0 ha 1 192.168.195.162 21M; gluster-block create dht/block0 ha 1 192.168.195.162 21M; targetcli ls
IQN: iqn.2016-12.org.gluster-block:12d49c06-78d0-447b-974e-6bd37ee15507
PORTAL(S): 192.168.195.162:3260
RESULT: SUCCESS
IQN: -
PORTAL(S): -
ROLLBACK FAILED ON: 192.168.195.162
RESULT: FAIL
o- / ......................................................................................................................... [...]
o- backstores .............................................................................................................. [...]
| o- block .................................................................................................. [Storage Objects: 0]
| o- fileio ................................................................................................. [Storage Objects: 0]
| o- pscsi .................................................................................................. [Storage Objects: 0]
| o- ramdisk ................................................................................................ [Storage Objects: 0]
| o- user:glfs .............................................................................................. [Storage Objects: 1]
| o- block0 ........................ [dht1@192.168.195.162/block-store/12d49c06-78d0-447b-974e-6bd37ee15507 (21.0MiB) activated]
| o- alua ................................................................................................... [ALUA Groups: 3]
| o- default_tg_pt_gp ....................................................................... [ALUA state: Active/optimized]
| o- glfs_tg_pt_gp_ano .................................................................. [ALUA state: Active/non-optimized]
| o- glfs_tg_pt_gp_ao ....................................................................... [ALUA state: Active/optimized]
o- iscsi ............................................................................................................ [Targets: 2]
| o- iqn.2016-12.org.gluster-block:12d49c06-78d0-447b-974e-6bd37ee15507 ................................................ [TPGs: 1]
| | o- tpg1 .................................................................................................. [gen-acls, no-auth]
| | o- acls .......................................................................................................... [ACLs: 0]
| | o- luns .......................................................................................................... [LUNs: 1]
| | | o- lun0 ................................................................................. [user/block0 (glfs_tg_pt_gp_ao)]
| | o- portals .................................................................................................... [Portals: 1]
| | o- 192.168.195.162:3260 ............................................................................................. [OK]
| o- iqn.2016-12.org.gluster-block:42b295bc-cdf0-457c-adda-fd1b3839575a ................................................ [TPGs: 1]
| o- tpg1 .................................................................................................. [gen-acls, no-auth]
| o- acls .......................................................................................................... [ACLs: 0]
| o- luns .......................................................................................................... [LUNs: 1]
| | o- lun0 ................................................................................. [user/block0 (glfs_tg_pt_gp_ao)]
| o- portals .................................................................................................... [Portals: 1]
| o- 192.168.195.162:3260 ............................................................................................. [OK]
o- loopback ......................................................................................................... [Targets: 0]
o- vhost ............................................................................................................ [Targets: 0]
o- xen-pvscsi ....................................................................................................... [Targets: 0]
]#
In the /etc/target/saveconfig.json we can see the Target's gbid is not the same with StorageObject's:
]# cat /etc/target/saveconfig.json
{
"storage_objects": [
{
"alua_tpgs": [
{
"alua_access_state": 1,
"alua_access_status": 2,
"alua_access_type": 1,
"alua_support_active_nonoptimized": 1,
"alua_support_active_optimized": 1,
"alua_support_offline": 1,
"alua_support_standby": 1,
"alua_support_transitioning": 1,
"alua_support_unavailable": 1,
"alua_write_metadata": 0,
"implicit_trans_secs": 0,
"name": "glfs_tg_pt_gp_ano",
"nonop_delay_msecs": 100,
"preferred": 0,
"tg_pt_gp_id": 2,
"trans_delay_msecs": 0
},
{
"alua_access_state": 0,
"alua_access_status": 0,
"alua_access_type": 1,
"alua_support_active_nonoptimized": 1,
"alua_support_active_optimized": 1,
"alua_support_offline": 1,
"alua_support_standby": 1,
"alua_support_transitioning": 1,
"alua_support_unavailable": 1,
"alua_write_metadata": 0,
"implicit_trans_secs": 0,
"name": "glfs_tg_pt_gp_ao",
"nonop_delay_msecs": 100,
"preferred": 0,
"tg_pt_gp_id": 1,
"trans_delay_msecs": 0
},
{
"alua_access_state": 0,
"alua_access_status": 0,
"alua_access_type": 3,
"alua_support_active_nonoptimized": 1,
"alua_support_active_optimized": 1,
"alua_support_offline": 1,
"alua_support_standby": 1,
"alua_support_transitioning": 1,
"alua_support_unavailable": 1,
"alua_write_metadata": 0,
"implicit_trans_secs": 0,
"name": "default_tg_pt_gp",
"nonop_delay_msecs": 100,
"preferred": 0,
"tg_pt_gp_id": 0,
"trans_delay_msecs": 0
}
],
"attributes": {
"cmd_time_out": 130,
"dev_size": 22020096,
"qfull_time_out": -1
},
"config": "glfs/dht1@192.168.195.162/block-store/12d49c06-78d0-447b-974e-6bd37ee15507",
"control": "max_data_area_mb=8,hw_block_size=512",
"hw_max_sectors": 128,
"name": "block0",
"plugin": "user",
"size": 22020096,
"wwn": "12d49c06-78d0-447b-974e-6bd37ee15507"
}
],
"targets": [
{
"fabric": "iscsi",
"tpgs": [
{
"attributes": {
"authentication": 0,
"cache_dynamic_acls": 1,
"default_cmdsn_depth": 64,
"default_erl": 0,
"demo_mode_discovery": 1,
"demo_mode_write_protect": 0,
"fabric_prot_type": 0,
"generate_node_acls": 1,
"login_timeout": 15,
"netif_timeout": 2,
"prod_mode_write_protect": 0,
"t10_pi": 0,
"tpg_enabled_sendtargets": 1
},
"enable": true,
"luns": [
{
"alias": "81f9fa86eb",
"alua_tg_pt_gp_name": "glfs_tg_pt_gp_ao",
"index": 0,
"storage_object": "/backstores/user/block0"
}
],
"node_acls": [],
"parameters": {
"AuthMethod": "CHAP,None",
"DataDigest": "CRC32C,None",
"DataPDUInOrder": "Yes",
"DataSequenceInOrder": "Yes",
"DefaultTime2Retain": "20",
"DefaultTime2Wait": "2",
"ErrorRecoveryLevel": "0",
"FirstBurstLength": "65536",
"HeaderDigest": "CRC32C,None",
"IFMarkInt": "Reject",
"IFMarker": "No",
"ImmediateData": "Yes",
"InitialR2T": "Yes",
"MaxBurstLength": "262144",
"MaxConnections": "1",
"MaxOutstandingR2T": "1",
"MaxRecvDataSegmentLength": "8192",
"MaxXmitDataSegmentLength": "262144",
"OFMarkInt": "Reject",
"OFMarker": "No",
"TargetAlias": "LIO Target"
},
"portals": [
{
"ip_address": "192.168.195.162",
"iser": false,
"offload": false,
"port": 3260
}
],
"tag": 1
}
],
"wwn": "iqn.2016-12.org.gluster-block:42b295bc-cdf0-457c-adda-fd1b3839575a"
}
]
}
]# 
pkalever
What does this PR achieve? Why do we need it?
create: split the creation into 2 phases
This will fix the following issues:
1, When the StorageObject creation failed the iqn will still be created and won't be deleted in case of:
When creating BV with the same NAME, the second time it will fail due to the targetcli cache db only allows one [user/$NAME] exist, but will leave the iqn not deleted correctly.
That means there will be two different Targets will both mapped to the same StorageObject.
2, For the case above we will also find that after the second creation failing the /etc/target/saveconfig.json will be one StorageObject with the second Target in pairs and exist.
In theory, there should be one StorageObject with 2 Targets.
This patch will split the creation into 2 phases: CREATE_SO_SRV and CREATE_TG_SRV, since in the targetcli it will build the cache by using the key = [usr/$NAME], so only the StorageObject is successfully created the second phase will make sense.
Does this PR fix issues?
Fixes: BZ#1725009