upgrade_activities: always wait till the background daemon is terminated

gluster / gluster-block

A framework for gluster block storage

GNU General Public License v2.0

74 stars 32 forks source link

upgrade_activities: always wait till the background daemon is terminated #246

Closed lxbsz closed 5 years ago

lxbsz commented 5 years ago

What does this PR achieve? Why do we need it?

When the upgrade activities script finishes and exit successfully, the gluster-blockd daemon running in the background may still not killed, so this will be a problem when the gluster-block service try to start:

ERROR: gluster-blockd is already running...

And also when running the gluster-blockd daemon in background it may need a while to get fired, so here will always try 5 times by waiting 1 second each time.

lxbsz commented 5 years ago

@pkalever Updated them all. Thanks.

lxbsz commented 5 years ago

@lxbsz BTW - did you check the complete script and tested this with no BHV's and with BHV & BV's in it ?

Yeah, test it with 3 BHVs and some BVs in them.

And test it by deleting all the BHVs again.

All works as expected in my side.

Thanks!

lxbsz commented 5 years ago

@pkalever Fixed them both. Thanks.

lxbsz commented 5 years ago

@pkalever Done. Thanks.

pkalever commented 5 years ago

Thanks @lxbsz , merged now.