search

gluster / gluster-block

A framework for gluster block storage
GNU General Public License v2.0
74 stars 32 forks source link

cleanup: remove unsupported code #248

Closed pkalever closed 5 years ago

pkalever commented 5 years ago

What does this PR achieve? Why do we need it?

Previously we had code which allows passing more than HA number of hosts to the create command. But the future was incomplete and this code was left dead.

This PR removes it all, may be once we have self-healing, this sort of feature addition becomes more easy.

Signed-off-by: Prasanna Kumar Kalever prasanna.kalever@redhat.com

Notes for the reviewer

This removes a lot of complexity at server side create code, both in terms of readability and back and forth within the code.

pkalever commented 5 years ago

@lxbsz updated. please take a look.

pkalever commented 5 years ago

@lxbsz actually inet_pton return 0 and -1 on failures. And on success it return 1.

Fixed that part too. Hope you noted it. Thanks!

lxbsz commented 5 years ago

@lxbsz actually inet_pton return 0 and -1 on failures. And on success it return 1.

Fixed that part too. Hope you noted it. Thanks! @pkalever

Yeah, cool. I saw that. Thanks.

pkalever commented 5 years ago

Merged now. Thanks!