search

gluster / gluster-containers

Dockerfiles (CentOS, Fedora, Red Hat) for GlusterFS
https://github.com/gluster/gluster-containers/pkgs/container/gluster-containers
223 stars 135 forks source link

[deploy] Use GH Actions to build and publish to GHCR #183

Closed black-dragon74 closed 2 years ago

black-dragon74 commented 2 years ago

Signed-off-by: black-dragon74 nickk.2974@gmail.com

black-dragon74 commented 2 years ago

Not that this should only get merged when the GLFS_SKEY token is available in the repository settings.

Tagging people who might add this to the repo.

/cc: @mscherer @deepshikhaaa @rakshithakamath94

Regards

mscherer commented 2 years ago

I think it would be useful to also add test on the PR, not just push to the registry. Not sure what is the best way to not duplicate the code too much.

black-dragon74 commented 2 years ago

I think it would be useful to also add test on the PR, not just push to the registry.

Noted. It’ll just require a separate workflow that runs only on PRs as we’ll only need the tests and not push anything.

I have another patch in the works that’ll test the built docker images too.

Regards

nixpanic commented 2 years ago

On Fri, Jul 08, 2022 at 05:59:59AM -0700, Niraj Kumar Yadav wrote:

@black-dragon74 commented on this pull request. ... Sure. This was my first experience with GH actions. So I went the manual route (to learn stuff). I will switch to those actions when we add multi platform builds (arm64).

Ok!

black-dragon74 commented 2 years ago

@mscherer Can you please add the repo secret?

Regards

nixpanic commented 2 years ago

I think it would be useful to also add test on the PR, not just push to the registry. Not sure what is the best way to not duplicate the code too much.

Pushing container-images was done with Travis CI earlier, so this GitHub Action looks like a good replacement. Additional workflows that test a PR would surely be nice, but that is a different task that can be done later.

mscherer commented 2 years ago

@black-dragon74 what do you mean, adding the repo secret ?

black-dragon74 commented 2 years ago

@black-dragon74 what do you mean, adding the repo secret ?

That's no longer required. GitHub recommends using GITHUB_TOKEN anyways.

I'll implement it tomorrow.

Regards