search

gluster / gluster-csi-driver

DEPRECATED: Gluster Container Storage Interface (CSI) driver
GNU Lesser General Public License v3.0
57 stars 30 forks source link

Update Kube dependency to v1.13.0 #115

Closed humblec closed 5 years ago

humblec commented 6 years ago

Signed-off-by: Humble Chirammal hchiramm@redhat.com

Describe what this PR does Provide some context for the reviewer

Is there anything that requires special attention? Do you have any questions? Did you do something clever?

Related issues: Mention any github issues relevant to this PR

humblec commented 6 years ago

@Madhu-1 PTAL .

Madhu-1 commented 6 years ago

@humblec CI failure

Madhu-1 commented 5 years ago

CI can be fixed by below changes

sample output after making these changes

[mrajanna@localhost gluster-csi-driver]$ ./scripts/lint-go.sh 
DEBUG: [Dec  6 06:47:12.631] [vetshadow.1]: vetshadow linter took 43.927215036s
DEBUG: [Dec  6 06:47:23.552] [structcheck.2]: structcheck linter took 10.920156351s
DEBUG: [Dec  6 06:47:23.555] [goconst.3]: goconst linter took 2.708084ms
DEBUG: [Dec  6 06:47:34.254] [vet.4]: vet linter took 10.698884799s
DEBUG: [Dec  6 06:48:16.302] [megacheck.5]: megacheck linter took 42.04788453s
DEBUG: [Dec  6 06:48:16.319] [ineffassign.6]: ineffassign linter took 17.092694ms
DEBUG: [Dec  6 06:48:30.874] [varcheck.7]: varcheck linter took 14.555044097s
DEBUG: [Dec  6 06:48:41.985] [gosec.8]: gosec linter took 11.109742231s
DEBUG: [Dec  6 06:48:52.571] [unconvert.9]: unconvert linter took 10.585713809s
DEBUG: [Dec  6 06:48:58.225] [gotype.10]: gotype linter took 5.653859138s
DEBUG: [Dec  6 06:49:03.983] [gotype.11]: gotype linter took 5.758298169s
DEBUG: [Dec  6 06:49:03.985] [gotype.12]: gotype linter took 1.987287ms
DEBUG: [Dec  6 06:49:14.619] [maligned.13]: maligned linter took 10.633908875s
DEBUG: [Dec  6 06:49:14.639] [gocyclo.14]: gocyclo linter took 19.04284ms
DEBUG: [Dec  6 06:49:14.666] [gofmt.15]: gofmt linter took 27.22844ms
DEBUG: [Dec  6 06:49:14.676] [deadcode.16]: deadcode linter took 8.97322ms
DEBUG: [Dec  6 06:49:29.545] [interfacer.17]: interfacer linter took 14.868778998s
DEBUG: [Dec  6 06:49:29.590] [golint.18]: golint linter took 45.267362ms
DEBUG: [Dec  6 06:49:29.592] [gotypex.19]: gotypex linter took 1.393034ms
DEBUG: [Dec  6 06:49:29.593] [gotypex.20]: gotypex linter took 1.274557ms
DEBUG: [Dec  6 06:49:29.594] [gotypex.21]: gotypex linter took 1.17297ms
DEBUG: [Dec  6 06:49:35.262] [errcheck.22]: errcheck linter took 5.667733925s
[mrajanna@localhost gluster-csi-driver]$
humblec commented 5 years ago

Merging this PR as it need a manual intervention to replay the docker image back to previous version.