gluster / gluster-csi-driver

DEPRECATED: Gluster Container Storage Interface (CSI) driver
GNU Lesser General Public License v3.0
57 stars 30 forks source link

Remove timeout from gml #129

Closed JohnStrunk closed 5 years ago

JohnStrunk commented 5 years ago

Describe what this PR does cloud.docker.com has been timing out when building the container, and it looks like this may be due to the linter timing out. This removes the timeout.

Is there anything that requires special attention? I probably shouldn't have put in the timeout to start with. :disappointed:

Related issues: Fixes #128

centos-ci commented 5 years ago

Can one of the admins verify this patch?

jarrpa commented 5 years ago

@JohnStrunk Looking at gometalinter --help, I'm gonna guess you set it because the default is 30s. Maybe increase it to 20m or 30m

JohnStrunk commented 5 years ago

Ah yes... the default. Trying again w/ 24h timeout. I had originally chosen 9m because Travis times out if there's no output for 10m, though that problem was worked around via the debug output. (and it turns out there's a way to fix it in travis too).